You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Alexander Shopov (JIRA)" <ji...@apache.org> on 2015/10/08 08:57:28 UTC
[jira] [Commented] (CASSANDRA-8755) Replace trivial uses of
String.replace/replaceAll/split with StringUtils methods
[ https://issues.apache.org/jira/browse/CASSANDRA-8755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14948175#comment-14948175 ]
Alexander Shopov commented on CASSANDRA-8755:
---------------------------------------------
Hello,
I am Alexander Shopov and would like to lend a hand with this patch.
I have updated it and I am attaching it to this bug report.
Only 11 files are changed. I have incorporated Oded's recommendation and extended them as the fast path also works in cases like "\n". I have also replaced String.replaceAll with String.replace in cases where regex literals rather than meta characters are used - the regex is still constructed but this goes via special and faster 'LITERAL' path.
I will be very surprised if this change buys measurable performance. If not - I think this issue can be closed.
In case you decide to actually merge - please also add Mengyu Zhang in the commit message as he started this.
> Replace trivial uses of String.replace/replaceAll/split with StringUtils methods
> --------------------------------------------------------------------------------
>
> Key: CASSANDRA-8755
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8755
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jaroslav Kamenik
> Priority: Trivial
> Labels: lhf
> Attachments: trunk-8755.patch, trunk-8755.txt
>
>
> There are places in the code where those regex based methods are used with plain, not regexp, strings, so StringUtils alternatives should be faster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)