[GitHub] [flink] aljoscha commented on a change in pull request #12853: [FLINK-18524][table-common] Fix type inference for Scala varargs

[GitBox <gi...@apache.org>]

aljoscha commented on a change in pull request #12853:
URL: https://github.com/apache/flink/pull/12853#discussion_r451517780



##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/FunctionMappingExtractor.java
##########
@@ -174,6 +178,39 @@ boolean hasAccumulator() {
 		return collectedMappings;
 	}
 
+	/**
+	 * Special case for Scala which generates two methods when using var-args (a {@code Seq < String >}
+	 * and {@code String...}). This method searches for the Java-like variant.
+	 */
+	private static Method adjustMethod(Method method) {

Review comment:
       This could be called sth like `correctVarargMethod()` that describes what it does in the method name.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org