You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/10/30 14:50:17 UTC
[GitHub] flink pull request #4923: [FLINK-7418][build] Integrate flink-shaded-jackson...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4923
[FLINK-7418][build] Integrate flink-shaded-jackson2
## What is the purpose of the change
This PR replaces all usages of com.fasterxml.jackson with flink-shaded-jackson.
One change of note is that flink-mesos now shades com.netflix.fenzo:fenzo-core so that it can use its own jackson version.
## Brief change log
* replace all jackson dependencies with flink-shaded-jackson
* add used undeclared dependencies to many modules
* replace all usages of com.fasterxml.jackson with org.apache.flink.shaded.jackson2.com.fasterxml.jackson
* modify mesos shade-plugin configuration to shade fenzo-core
* modify quickstarts to exclude flink-shaded-jackson instead
* (implicit) bump jackson version to 2.7.9
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7418
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4923.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4923
----
commit bac19a90544fba63693983970dece1a4fee5f14a
Author: zentol <ch...@apache.org>
Date: 2017-10-16T10:48:12Z
[FLINK-7418][build] Integrate flink-shaded-jackson2
commit 97dcac37a783a746d1d6c77099d6a241febb22e6
Author: zentol <ch...@apache.org>
Date: 2017-10-16T10:49:38Z
kafka
commit ee8ae4d312193f288e7b671f13efd69a827dca58
Author: zentol <ch...@apache.org>
Date: 2017-10-16T10:51:11Z
gelly
commit fa1dd1e9a0bb6af4ce2d2a4a7c6bcd502dbfaa99
Author: zentol <ch...@apache.org>
Date: 2017-10-16T10:51:46Z
streaming examples
commit 39fbd1a66f94bff3d01231a1d9028ca5e534186a
Author: zentol <ch...@apache.org>
Date: 2017-10-16T10:52:23Z
DataDog reporter
commit 6725ef65ce0e0c8e45c5002ea47d66f9e3e5aa28
Author: zentol <ch...@apache.org>
Date: 2017-10-16T10:53:37Z
runtime-web
commit 7d661a849d3c7eca0dda676492bf852ab598d2f0
Author: zentol <ch...@apache.org>
Date: 2017-10-16T10:54:30Z
optimizer
commit 87f2dc8e9fcad3c69ce166e853cac3a3c4b89039
Author: zentol <ch...@apache.org>
Date: 2017-10-16T10:56:09Z
flink-tests
commit 81af03d9560b1da043b4a211ece8092df2b17c61
Author: zentol <ch...@apache.org>
Date: 2017-10-16T10:57:08Z
mesos
commit 6fa19385f343675737fc0d0c8e06366167662af5
Author: zentol <ch...@apache.org>
Date: 2017-10-16T10:59:14Z
quickstarts
commit 5d27f2cade24a37b6d22427d01cf2d3274f62feb
Author: zentol <ch...@apache.org>
Date: 2017-10-16T10:59:43Z
table
commit 992fb2ebfbb100a69d22e100b6ec217672f14b76
Author: zentol <ch...@apache.org>
Date: 2017-10-16T11:01:06Z
streaming-java
commit f3c645c8fa415181cea42bc8039897516ddd26a4
Author: zentol <ch...@apache.org>
Date: 2017-10-16T11:01:55Z
yarn-tests
commit 90abe30d7dc762e64231ef47ddd1ed40d0d80cb5
Author: zentol <ch...@apache.org>
Date: 2017-10-16T11:03:43Z
runtime
----
---
[GitHub] flink issue #4923: [FLINK-7418][build] Integrate flink-shaded-jackson2
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4923
Ok for me.
---
[GitHub] flink issue #4923: [FLINK-7418][build] Integrate flink-shaded-jackson2
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4923
It's more of an assumption tbh, i haven't tried it out. I've looked through the fenzo source code to search for APIs that expose jackson but couldn't find any. They annotate a number of POJOs but don't even map them to/from JSON outside of tests.
---
[GitHub] flink pull request #4923: [FLINK-7418][build] Integrate flink-shaded-jackson...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4923
---
[GitHub] flink issue #4923: [FLINK-7418][build] Integrate flink-shaded-jackson2
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4923
Changes look good. :+1:
How do we know that our Mesos support still works when Jackson is shaded there?
---