You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@spamassassin.apache.org by ms...@apache.org on 2004/07/27 20:27:23 UTC

svn commit: rev 30793 - spamassassin/trunk/spamc

Author: mss
Date: Tue Jul 27 11:27:23 2004
New Revision: 30793

Modified:
   spamassassin/trunk/spamc/Makefile.in
Log:
bug 3599: Removed -Wall from the CFLAGS for now to make it compile with non-GCC compilers. The file configure.in is currently broken and needs some love for 3.1.


Modified: spamassassin/trunk/spamc/Makefile.in
==============================================================================
--- spamassassin/trunk/spamc/Makefile.in	(original)
+++ spamassassin/trunk/spamc/Makefile.in	Tue Jul 27 11:27:23 2004
@@ -1,6 +1,6 @@
 CC = @CC@
 
-CFLAGS = -Wall @CFLAGS@
+CFLAGS = @CFLAGS@
 SSLCFLAGS = @SSLCFLAGS@
 
 CCDLFLAGS = @CCDLFLAGS@

Re: svn commit: rev 30793 - spamassassin/trunk/spamc

Posted by Daniel Quinlan <qu...@pathname.com>.

> bug 3599: Removed -Wall from the CFLAGS for now to make it compile
> with non-GCC compilers. The file configure.in is currently broken and
> needs some love for 3.1.

-1 the cure is worse than the disease

I think this is a bad idea, especially considering the problems we're
having with the spamc code, 99% of the sites compiling spamc use GCC
and we want -Wall for those.  Can you please revert this change?

Thanks.

-- 
Daniel Quinlan
http://www.pathname.com/~quinlan/