[GitHub] [ignite-3] lowka commented on a diff in pull request #1777: IGNITE-18966: Sql. Custom data types. Fix least restrictive type and nullability.

["lowka (via GitHub)" <gi...@apache.org>]

lowka commented on code in PR #1777:
URL: https://github.com/apache/ignite-3/pull/1777#discussion_r1137091576


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItImplicitCastsTest.java:
##########
@@ -46,7 +54,10 @@ public void dropTables() {
     public void testFilter(ColumnPair columnPair) {
         prepareTables(columnPair);
 
-        assertQuery("SELECT T11.c2 FROM T11 WHERE T11.c2 > 1.0").check();
+        String value = columnPair.lhsLiteral(0);
+        String query = format("SELECT T11.c2 FROM T11 WHERE T11.c2 > CAST({} AS {})", value, columnPair.rhs);

Review Comment:
   An implicit cast is added to the left side of an expression ( T11.c2.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org