You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/17 13:06:31 UTC
[GitHub] [airflow] potiuk opened a new pull request #19645: Fix dumping container logs on error
potiuk opened a new pull request #19645:
URL: https://github.com/apache/airflow/pull/19645
When we optimized tests for memory use we added cleanup of all
containers after each test suite. Unfortunately it caused
dumping container logs to stop working because this dumping was
done only only when the script was exiting.
This PR moves dumping container logs to between the test run and
cleanup, so that we can see the logs when there is a test failure.
Related to: #19633 where the logs were not dumped and it made the
analysis much more difficult.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #19645: Fix dumping container logs on error
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #19645:
URL: https://github.com/apache/airflow/pull/19645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19645: Fix dumping container logs on error
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19645:
URL: https://github.com/apache/airflow/pull/19645#issuecomment-971561525
cc: @khalidmammadov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19645: Fix dumping container logs on error
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19645:
URL: https://github.com/apache/airflow/pull/19645#issuecomment-971599863
You can see container logs nicely uploaded here: https://github.com/apache/airflow/actions/runs/1471691334
BTW. It would not help with diagnosing the problem we had - pinot logs are not showig anything suspicious. It looks like error was caused by bad health-check. I will add a `docker ps` command on failure so that we can match the container hash with the "health" check error (unfortunately the health check only shows HASH of the container that failed the health check)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19645: Fix dumping container logs on error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19645:
URL: https://github.com/apache/airflow/pull/19645#issuecomment-971872085
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19645: Fix dumping container logs on error
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19645:
URL: https://github.com/apache/airflow/pull/19645#issuecomment-971829460
@ashb I saw you wanted to fix it before -the reason it did not work was that we cleaned-up containers to save memory and dumping container logs was executed after that :facepalm: - this should help with diagnosing similar issues as with #19633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org