You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/16 14:51:26 UTC
[GitHub] [cloudstack] andrijapanicsb opened a new issue #3816: "restart
required : yes" is never set to "no" after network/VPC restart
andrijapanicsb opened a new issue #3816: "restart required : yes" is never set to "no" after network/VPC restart
URL: https://github.com/apache/cloudstack/issues/3816
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and master branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Bug Report
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java#L1719-L1764
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on master branch.
-->
~~~
4.13
~~~
##### CONFIGURATION/SUMMARY/ETC
<!--
Information about the configuration if relevant, e.g. basic network, advanced networking, etc. N/A otherwise
-->
When a network is showing as "Restart required: yes" in the GUI (field "restart_required"="1" in cloud.networks table) - there is no way to "fix" this (set it back to "no")
Confirmed by manually setting "1" in the DB for multiple Shared, non-VPC Isolated networks and VPC Isolated networks.
Restart (no cleanup) doesn't work
Restart (with cleanup) doesn't work
The only way seems to be to hack the DB to set
The code provided above does set this for the VPC itself, not for it's networks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3816: "restart
required : yes" is never set to "no" after network/VPC restart
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3816: "restart required : yes" is never set to "no" after network/VPC restart
URL: https://github.com/apache/cloudstack/issues/3816#issuecomment-607189217
Ok, I didn't test restarting the VPC. My test only included restarting the network in the VPC. I'll look into it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3816: "restart
required : yes" is never set to "no" after network/VPC restart
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3816: "restart required : yes" is never set to "no" after network/VPC restart
URL: https://github.com/apache/cloudstack/issues/3816#issuecomment-607229960
Restarting the VPC did not restart the network. I'll work on a fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3816: "restart
required : yes" is never set to "no" after network/VPC restart
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3816: "restart required : yes" is never set to "no" after network/VPC restart
URL: https://github.com/apache/cloudstack/issues/3816#issuecomment-581953289
Not completely addressed - when you restart VPC with cleanup, it does NOT mark the field as 0 in DB, thus all VPC networks still show as requiring a restart. Thus reopening the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 edited a comment on issue #3816: "restart
required : yes" is never set to "no" after network/VPC restart
Posted by GitBox <gi...@apache.org>.
Spaceman1984 edited a comment on issue #3816: "restart required : yes" is never set to "no" after network/VPC restart
URL: https://github.com/apache/cloudstack/issues/3816#issuecomment-607189217
Ok @andrijapanicsb, I didn't test restarting the VPC. My test only included restarting the network in the VPC. I'll look into it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb opened a new issue #3816: "restart
required : yes" is never set to "no" after network/VPC restart
Posted by GitBox <gi...@apache.org>.
andrijapanicsb opened a new issue #3816: "restart required : yes" is never set to "no" after network/VPC restart
URL: https://github.com/apache/cloudstack/issues/3816
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and master branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Improvement request
(perhaps a bug?)
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java#L1719-L1764
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on master branch.
-->
~~~
4.13
~~~
##### CONFIGURATION/SUMMARY/ETC
<!--
Information about the configuration if relevant, e.g. basic network, advanced networking, etc. N/A otherwise
-->
When a network is showing as "Restart required: yes" in the GUI (field "restart_required"="1" in cloud.networks table) - there is no way to "fix" this (set it back to "no")
Confirmed by manually setting "1" in the DB for multiple Shared, non-VPC Isolated networks and VPC Isolated networks.
Restart (no cleanup) doesn't work
Restart (with cleanup) doesn't work
The only way seems to be to hack the DB to set
The code provided above does set this for the VPC itself, not for it's networks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3816: "restart
required : yes" is never set to "no" after network/VPC restart
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3816: "restart required : yes" is never set to "no" after network/VPC restart
URL: https://github.com/apache/cloudstack/issues/3816#issuecomment-607183907
It can't be gone by its own? See this comment from Wei https://github.com/apache/cloudstack/pull/3803#issuecomment-581936011
Can you trace any commit that would have fixed the thing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3816: "restart
required : yes" is never set to "no" after network/VPC restart
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3816: "restart required : yes" is never set to "no" after network/VPC restart
URL: https://github.com/apache/cloudstack/issues/3816#issuecomment-607151116
@andrijapanicsb, I tested networks and VPC with and without cleanup. I was not able to reproduce the error. Seems like this is no longer an issue and can be closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3816: "restart required :
yes" is never set to "no" after network/VPC restart
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3816: "restart required : yes" is never set to "no" after network/VPC restart
URL: https://github.com/apache/cloudstack/issues/3816#issuecomment-580679691
https://github.com/apache/cloudstack/pull/3803
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 removed a comment on issue #3816:
"restart required : yes" is never set to "no" after network/VPC restart
Posted by GitBox <gi...@apache.org>.
Spaceman1984 removed a comment on issue #3816: "restart required : yes" is never set to "no" after network/VPC restart
URL: https://github.com/apache/cloudstack/issues/3816#issuecomment-607151116
@andrijapanicsb, I tested networks and VPC with and without cleanup. I was not able to reproduce the error. Seems like this is no longer an issue and can be closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd closed issue #3816: "restart required : yes" is
never set to "no" after network/VPC restart
Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #3816: "restart required : yes" is never set to "no" after network/VPC restart
URL: https://github.com/apache/cloudstack/issues/3816
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3816:
"restart required : yes" is never set to "no" after network/VPC restart
Posted by GitBox <gi...@apache.org>.
andrijapanicsb edited a comment on issue #3816: "restart required : yes" is never set to "no" after network/VPC restart
URL: https://github.com/apache/cloudstack/issues/3816#issuecomment-581953289
Not completely addressed by #3803 - when you restart VPC with cleanup, it does NOT mark the field as 0 in DB (per @weizhouapache testing), thus all VPC networks still show as requiring a restart. Thus reopening the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3816: "restart
required : yes" is never set to "no" after network/VPC restart
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3816: "restart required : yes" is never set to "no" after network/VPC restart
URL: https://github.com/apache/cloudstack/issues/3816#issuecomment-607160061
I have tested on 4.13.1 with isolated, shared and L2 networks and a VPC network. In all instances, the restart required flag was reset with and without cleanup. @andrijapanicsb this doesn't seem like an issue anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services