You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Patrick Lightbody (JIRA)" <ji...@codehaus.org> on 2006/01/20 19:52:06 UTC

[jira] Created: (MIDEA-24) Resources should be in the classpath, not sources

Resources should be in the classpath, not sources
-------------------------------------------------

         Key: MIDEA-24
         URL: http://jira.codehaus.org/browse/MIDEA-24
     Project: Maven 2.x Idea Plugin
        Type: Improvement

    Reporter: Patrick Lightbody
 Attachments: idea.resources.diff

I think resources should be marked in the classpath, not in the sources directory. Although sources can be copied, but defalt some files aren't (like .gif, .js, etc). Brett agreed this would be a fine change, so I am attaching a patch. Note: this patch is a bit ghetto since I didn't know how to tell if a java Resource is of the "resources" type or the "java source" type. Feel free to tweak the endsWith("resources") check as needed :)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MIDEA-24) Resources should be in the classpath, not sources

Posted by "Edwin Punzalan (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MIDEA-24?page=all ]
     
Edwin Punzalan closed MIDEA-24:
-------------------------------

     Assign To: Edwin Punzalan
    Resolution: Fixed

Patch applied. Thanks.

All the directories listed in project.getBuild().getResources() are all resource directories, btw. ^_^

> Resources should be in the classpath, not sources
> -------------------------------------------------
>
>          Key: MIDEA-24
>          URL: http://jira.codehaus.org/browse/MIDEA-24
>      Project: Maven 2.x Idea Plugin
>         Type: Improvement

>     Reporter: Patrick Lightbody
>     Assignee: Edwin Punzalan
>      Fix For: 2.0
>  Attachments: idea.resources.diff
>
>
> I think resources should be marked in the classpath, not in the sources directory. Although sources can be copied, but defalt some files aren't (like .gif, .js, etc). Brett agreed this would be a fine change, so I am attaching a patch. Note: this patch is a bit ghetto since I didn't know how to tell if a java Resource is of the "resources" type or the "java source" type. Feel free to tweak the endsWith("resources") check as needed :)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MIDEA-24) Resources should be in the classpath, not sources

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MIDEA-24?page=comments#action_56718 ] 

Brett Porter commented on MIDEA-24:
-----------------------------------

will check two things before applying:
- proper replacement for the resources check
- compare to m1 plugin behaviour

> Resources should be in the classpath, not sources
> -------------------------------------------------
>
>          Key: MIDEA-24
>          URL: http://jira.codehaus.org/browse/MIDEA-24
>      Project: Maven 2.x Idea Plugin
>         Type: Improvement

>     Reporter: Patrick Lightbody
>  Attachments: idea.resources.diff
>
>
> I think resources should be marked in the classpath, not in the sources directory. Although sources can be copied, but defalt some files aren't (like .gif, .js, etc). Brett agreed this would be a fine change, so I am attaching a patch. Note: this patch is a bit ghetto since I didn't know how to tell if a java Resource is of the "resources" type or the "java source" type. Feel free to tweak the endsWith("resources") check as needed :)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MIDEA-24) Resources should be in the classpath, not sources

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MIDEA-24?page=all ]

Brett Porter updated MIDEA-24:
------------------------------

    Fix Version: 2.0

> Resources should be in the classpath, not sources
> -------------------------------------------------
>
>          Key: MIDEA-24
>          URL: http://jira.codehaus.org/browse/MIDEA-24
>      Project: Maven 2.x Idea Plugin
>         Type: Improvement

>     Reporter: Patrick Lightbody
>      Fix For: 2.0
>  Attachments: idea.resources.diff
>
>
> I think resources should be marked in the classpath, not in the sources directory. Although sources can be copied, but defalt some files aren't (like .gif, .js, etc). Brett agreed this would be a fine change, so I am attaching a patch. Note: this patch is a bit ghetto since I didn't know how to tell if a java Resource is of the "resources" type or the "java source" type. Feel free to tweak the endsWith("resources") check as needed :)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org