You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jackye1995 (via GitHub)" <gi...@apache.org> on 2023/03/13 17:27:07 UTC

[GitHub] [iceberg] jackye1995 commented on a diff in pull request #7066: S3 Credentials provider support in DefaultAwsClientFactory #7063

jackye1995 commented on code in PR #7066:
URL: https://github.com/apache/iceberg/pull/7066#discussion_r1134368126


##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -339,6 +347,12 @@ public class AwsProperties implements Serializable {
    */
   public static final String CLIENT_ASSUME_ROLE_REGION = "client.assume-role.region";
 
+  /**
+   * Used by {@link org.apache.iceberg.aws.AwsClientFactories.DefaultAwsClientFactory}. If set, all
+   * AWS clients except STS client will use * the given region instead of the default region chain.
+   */
+  public static final String AWS_REGION = "aws.region";

Review Comment:
   in that case I think it's better to call it `client.region`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org