You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "efegokdemir (via GitHub)" <gi...@apache.org> on 2026/10/04 15:53:03 UTC

[PR] fix: remap nested TopK filter expressions before their children [datafusion]

efegokdemir opened a new pull request, #26031:
URL: https://github.com/apache/datafusion/pull/26031

   ## Which issue does this PR close?
   - Closes #26029.
   
   ## Rationale for this change
   TopK dynamic filtering can return incorrect rows when one sort expression contains another sort key. Child-first remapping changes the parent before it can be matched.
   
   ## What changes are included in this PR?
   Remap matching parent expressions before their descendants and stop traversing each replacement. Add the reported query as a SQL logic test.
   
   ## What is the testing strategy for this PR?
   - `cargo test --profile=ci --test sqllogictests -- topk_dynamic_filter_remap.slt`
   - `cargo test --profile=ci -p datafusion-physical-expr --lib` (1685 passed, 2 ignored)
   - `cargo fmt --all --check`
   - `cargo clippy --profile ci -p datafusion-physical-expr --lib -- -D warnings`
   - All-target Clippy passed with `-A clippy::ignore-without-reason` for an existing ignored test lacking a reason in `planner.rs`.
   
   The broader `topk.slt` file could not be validated because this shallow checkout does not include the `testing` submodule data.
   
   ## Are there any user-facing changes?
   Yes. Queries matching this case now return the correct TopK rows; there is no API change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] fix: remap nested TopK filter expressions before their children [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #26031:
URL: https://github.com/apache/datafusion/pull/26031#issuecomment-6531646361

   Thank you for the contribution. I am closing this under DataFusion's AI Dump policy: https://datafusion.apache.org/contributor-guide/ai-policy.html#what-is-an-ai-dump
   
   Rationale: the description says the `testing` submodule could not be checked out and lists clippy flags and local test counts, which the policy calls out as markers of unreviewed AI-generated content. The PR was marked draft on Oct 24 awaiting an author response to review feedback, CI is failing, and this account's other recent PR (#26894) was closed under the AI policy on Oct 29.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] fix: remap nested TopK filter expressions before their children [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed pull request #26031: fix: remap nested TopK filter expressions before their children
URL: https://github.com/apache/datafusion/pull/26031


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] fix: remap nested TopK filter expressions before their children [datafusion]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #26031:
URL: https://github.com/apache/datafusion/pull/26031#issuecomment-6349499554

   ## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/26031?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 82.66%. Comparing base ([`c3ef346`](https://app.codecov.io/gh/apache/datafusion/commit/c3ef346887412eeaeef644809c8fcfaf782f94e4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e0d86f`](https://app.codecov.io/gh/apache/datafusion/commit/4e0d86f97943aa6c11fdb2c0668fa25485f7be96?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 246 commits behind head on main.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@           Coverage Diff           @@
   ##             main   #26031   +/-   ##
   =======================================
     Coverage   82.66%   82.66%           
   =======================================
     Files        1147     1147           
     Lines      446357   446357           
     Branches   446357   446357           
   =======================================
   + Hits       368971   368978    +7     
   + Misses      54997    54988    -9     
   - Partials    22389    22391    +2     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/26031?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] fix: remap nested TopK filter expressions before their children [datafusion]

Posted by "rgbuilds (via GitHub)" <gi...@apache.org>.
rgbuilds commented on code in PR #26031:
URL: https://github.com/apache/datafusion/pull/26031#discussion_r4178915231


##########
datafusion/sqllogictest/test_files/topk_dynamic_filter_remap.slt:
##########
@@ -0,0 +1,51 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+statement ok

Review Comment:
   The end-to-end SLT provides strong coverage for #26029. Since remap_children is also shared by HashJoin and projection/scan pushdown, would it be valuable to add a focused unit test that registers both a parent expression and one of its descendants, while also checking that an unmatched parent still allows descendant remapping? Non-blocking—the reported wrong-result path is already covered by the SLT.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] fix: remap nested TopK filter expressions before their children [datafusion]

Posted by "kosiew (via GitHub)" <gi...@apache.org>.
kosiew commented on code in PR #26031:
URL: https://github.com/apache/datafusion/pull/26031#discussion_r4387310211


##########
datafusion/sqllogictest/test_files/topk_dynamic_filter_remap.slt:
##########
@@ -0,0 +1,88 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+statement ok
+SET datafusion.execution.target_partitions = 1;
+
+statement ok
+SET datafusion.execution.parquet.pushdown_filters = true;
+
+statement ok
+COPY (
+  SELECT value AS b FROM generate_series(0, 31999)
+) TO 'test_files/scratch/topk_dynamic_filter_remap.parquet'
+STORED AS PARQUET OPTIONS ('format.max_row_group_size' '500');
+
+statement ok
+CREATE EXTERNAL TABLE t STORED AS PARQUET
+LOCATION 'test_files/scratch/topk_dynamic_filter_remap.parquet';
+
+# A computed sort key avoids limit pushdown, so this plan must show TopK's
+# DynamicFilter at the Parquet scan.
+query TT
+EXPLAIN SELECT b FROM t ORDER BY b + 1 LIMIT 3;
+----
+logical_plan
+01)Sort: t.b + Int64(1) ASC NULLS LAST, fetch=3
+02)--TableScan: t projection=[b]
+physical_plan
+01)SortExec: TopK(fetch=3), expr=[b@0 + 1 ASC NULLS LAST], preserve_partitioning=[false]
+02)--DataSourceExec: file_groups={1 group: [[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/topk_dynamic_filter_remap.parquet]]}, projection=[b], output_ordering=[b@0 ASC NULLS LAST], file_type=parquet, predicate=DynamicFilter [ empty ], dynamic_rg_pruning=eligible
+
+# A CASE sort key that also references b must still plan TopK dynamic filtering
+# at the Parquet scan; the result assertion below alone would pass if filtering
+# were disabled.
+query TT
+EXPLAIN WITH s AS (SELECT b, 31999 - b AS p FROM t)
+SELECT p FROM s
+ORDER BY CASE WHEN b % 2 = 0 THEN p ELSE p + 1 END, b

Review Comment:
   Non-blocking: could we also EXPLAIN the exact result query below, using `ELSE q` with equal `p`/`q` expressions, and assert TopK plus the Parquet scan's dynamic predicate? The current `ELSE p + 1` query guards a related plan, but planner changes affecting only the equal-arm query could bypass dynamic filtering while these assertions still pass. Please retain the runtime result check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] fix: remap nested TopK filter expressions before their children [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #26031:
URL: https://github.com/apache/datafusion/pull/26031#issuecomment-6505177109

   CI seems failed due to 
   
   https://github.com/efegokdemir/datafusion/actions/runs/40868139546
   
   <img width="1082" height="1013" alt="Screenshot 2026-10-29 at 2 34 16 PM" src="https://github.com/user-attachments/assets/0e251f7c-ce4d-4761-ac6a-aa5c7a2f3739" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] fix: remap nested TopK filter expressions before their children [datafusion]

Posted by "kosiew (via GitHub)" <gi...@apache.org>.
kosiew commented on code in PR #26031:
URL: https://github.com/apache/datafusion/pull/26031#discussion_r4346289000


##########
datafusion/sqllogictest/test_files/topk_dynamic_filter_remap.slt:
##########
@@ -0,0 +1,51 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+statement ok
+SET datafusion.execution.target_partitions = 1;
+
+statement ok
+SET datafusion.execution.parquet.pushdown_filters = true;
+
+statement ok
+COPY (
+  SELECT value AS b FROM generate_series(0, 31999)
+) TO 'test_files/scratch/topk_dynamic_filter_remap.parquet'
+STORED AS PARQUET OPTIONS ('format.max_row_group_size' '500');
+
+statement ok
+CREATE EXTERNAL TABLE t STORED AS PARQUET
+LOCATION 'test_files/scratch/topk_dynamic_filter_remap.parquet';
+
+query I

Review Comment:
   Consider adding an EXPLAIN assertion confirming that the TopK dynamic filter reaches the Parquet scan. The result assertion could also pass with dynamic filtering disabled, so this would guard against planner changes bypassing the intended path while retaining the runtime result check.



##########
datafusion/sqllogictest/test_files/topk_dynamic_filter_remap.slt:
##########
@@ -0,0 +1,51 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+statement ok
+SET datafusion.execution.target_partitions = 1;
+
+statement ok
+SET datafusion.execution.parquet.pushdown_filters = true;
+
+statement ok
+COPY (
+  SELECT value AS b FROM generate_series(0, 31999)
+) TO 'test_files/scratch/topk_dynamic_filter_remap.parquet'
+STORED AS PARQUET OPTIONS ('format.max_row_group_size' '500');
+
+statement ok
+CREATE EXTERNAL TABLE t STORED AS PARQUET
+LOCATION 'test_files/scratch/topk_dynamic_filter_remap.parquet';
+
+query I
+WITH s AS (SELECT b, 31999 - b AS p, 31999 - b AS q FROM t)

Review Comment:
   Could you add a short comment explaining that the CASE sort key contains the second sort key (`b`), making child-first remapping problematic? The equal `p`/`q` expressions simplify expected results, while multiple Parquet row groups provide later scan input for updated TopK filtering.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] fix: remap nested TopK filter expressions before their children [datafusion]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26031:
URL: https://github.com/apache/datafusion/pull/26031#issuecomment-6344041502

   <!-- semver-check-comment -->
   Thank you for opening this pull request!
   
   Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).
   
   <details>
   <summary>Details</summary>
   
   ```
        Cloning apache/main
       Building datafusion-physical-expr v55.1.0 (current)
          Built [  36.350s] (current)
        Parsing datafusion-physical-expr v55.1.0 (current)
         Parsed [   0.057s] (current)
       Building datafusion-physical-expr v55.1.0 (baseline)
          Built [  35.761s] (baseline)
        Parsing datafusion-physical-expr v55.1.0 (baseline)
         Parsed [   0.056s] (baseline)
       Checking datafusion-physical-expr v55.1.0 -> v55.1.0 (no change; assume patch)
        Checked [   0.348s] 223 checks: 219 pass, 4 fail, 0 warn, 31 skip
   
   --- failure function_missing: pub fn removed or renamed ---
   
   Description:
   A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
           ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
          impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_missing.ron
   
   Failed in:
     function datafusion_physical_expr::proto::register_physical_expr, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/31ee0145cb027b1c55ea56bd1cead4d5f420c10e/datafusion/physical-expr/src/proto.rs:185
     function datafusion_physical_expr::proto::physical_expr_names, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/31ee0145cb027b1c55ea56bd1cead4d5f420c10e/datafusion/physical-expr/src/proto.rs:225
     function datafusion_physical_expr::proto::extension_expr_node, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/31ee0145cb027b1c55ea56bd1cead4d5f420c10e/datafusion/physical-expr/src/proto.rs:118
   
   --- failure inherent_method_missing: pub method removed or renamed ---
   
   Description:
   A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
           ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
          impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron
   
   Failed in:
     CastExpr::with_new_expr_and_target_field, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/31ee0145cb027b1c55ea56bd1cead4d5f420c10e/datafusion/physical-expr/src/expressions/cast.rs:292
   
   --- failure module_missing: pub module removed or renamed ---
   
   Description:
   A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public.
           ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
          impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/module_missing.ron
   
   Failed in:
     mod datafusion_physical_expr::proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/31ee0145cb027b1c55ea56bd1cead4d5f420c10e/datafusion/physical-expr/src/proto.rs:18
   
   --- failure trait_missing: pub trait removed or renamed ---
   
   Description:
   A publicly-visible trait cannot be imported by its prior path. A `pub use` may have been removed, or the trait itself may have been renamed or removed entirely.
           ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
          impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_missing.ron
   
   Failed in:
     trait datafusion_physical_expr::proto::ExtensionExprFromProto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/31ee0145cb027b1c55ea56bd1cead4d5f420c10e/datafusion/physical-expr/src/proto.rs:87
   
        Summary semver requires new major version: 4 major and 0 minor checks failed
       Finished [  73.809s] datafusion-physical-expr
       Building datafusion-sqllogictest v55.1.0 (current)
          Built [ 105.261s] (current)
        Parsing datafusion-sqllogictest v55.1.0 (current)
         Parsed [   0.016s] (current)
       Building datafusion-sqllogictest v55.1.0 (baseline)
          Built [ 103.715s] (baseline)
        Parsing datafusion-sqllogictest v55.1.0 (baseline)
         Parsed [   0.017s] (baseline)
       Checking datafusion-sqllogictest v55.1.0 -> v55.1.0 (no change; assume patch)
        Checked [   0.104s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip
   
   --- failure inherent_method_missing: pub method removed or renamed ---
   
   Description:
   A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
           ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
          impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron
   
   Failed in:
     DataFusionSubstraitRoundTrip::with_optimization, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/31ee0145cb027b1c55ea56bd1cead4d5f420c10e/datafusion/sqllogictest/src/engines/datafusion_substrait_roundtrip_engine/runner.rs:60
   
        Summary semver requires new major version: 1 major and 0 minor checks failed
       Finished [ 211.727s] datafusion-sqllogictest
   ```
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] fix: remap nested TopK filter expressions before their children [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #26031:
URL: https://github.com/apache/datafusion/pull/26031#issuecomment-6382874078

   This PR appears to be waiting on the author to respond to reviewer feedback so marking as draft. Please mark ready to review when it is ready for another look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] fix: remap nested TopK filter expressions before their children [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #26031:
URL: https://github.com/apache/datafusion/pull/26031#issuecomment-6507693776

   I think this one may be dead / from a banned account. Closing to keep the review load under control. Please reopen if that was a mistake


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org