You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Srinivas Brahmaroutu <sr...@us.ibm.com> on 2016/12/08 18:19:08 UTC
Re: Review Request 50414: Added variables for building Java Protobuf.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50414/
-----------------------------------------------------------
(Updated Dec. 8, 2016, 6:19 p.m.)
Review request for mesos, Alex Clemmer and Joseph Wu.
Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902
Repository: mesos
Description (updated)
-------
Added protobuf_java external project to 3rdparty.
This will setup PROTOBUF_JAVA_ROOT at location
<BUILD-ROOT>/3rdparty/protobuf_java-2.6.1/src/protobuf_java-2.6.1
and also define the PROTOBUF_JAR at the location
${PROTOBUF_JAVA_ROOT}/java/target/protobuf-java-2.6.1.jar
Diffs (updated)
-----
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake e9eabd08d327f4c714199f7bde91b9adf644a678
Diff: https://reviews.apache.org/r/50414/diff/
Testing
-------
cmake .. && make
Thanks,
Srinivas Brahmaroutu
Re: Review Request 50414: Added variables for building Java Protobuf.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50414/#review167508
-----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews.
- Joris Van Remoortere
On Dec. 10, 2016, 7:18 p.m., Srinivas Brahmaroutu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50414/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2016, 7:18 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Bugs: MESOS-5902
> https://issues.apache.org/jira/browse/MESOS-5902
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added protobuf_java external project to 3rdparty.
> This will setup PROTOBUF_JAVA_ROOT at location
> <BUILD-ROOT>/3rdparty/protobuf_java-2.6.1/src/protobuf_java-2.6.1
> and also define the PROTOBUF_JAR at the location
> ${PROTOBUF_JAVA_ROOT}/java/target/protobuf-java-2.6.1.jar
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake e9eabd08d327f4c714199f7bde91b9adf644a678
>
>
> Diff: https://reviews.apache.org/r/50414/diff/7/
>
>
> Testing
> -------
>
> cmake .. && make
>
>
> Thanks,
>
> Srinivas Brahmaroutu
>
>
Re: Review Request 50414: Added variables for building Java Protobuf.
Posted by Srinivas Brahmaroutu <sr...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50414/
-----------------------------------------------------------
(Updated Dec. 10, 2016, 7:18 p.m.)
Review request for mesos, Alex Clemmer and Joseph Wu.
Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902
Repository: mesos
Description
-------
Added protobuf_java external project to 3rdparty.
This will setup PROTOBUF_JAVA_ROOT at location
<BUILD-ROOT>/3rdparty/protobuf_java-2.6.1/src/protobuf_java-2.6.1
and also define the PROTOBUF_JAR at the location
${PROTOBUF_JAVA_ROOT}/java/target/protobuf-java-2.6.1.jar
Diffs (updated)
-----
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake e9eabd08d327f4c714199f7bde91b9adf644a678
Diff: https://reviews.apache.org/r/50414/diff/
Testing
-------
cmake .. && make
Thanks,
Srinivas Brahmaroutu