You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/06/20 13:39:41 UTC
[GitHub] [servicecomb-service-center] codecov-io commented on issue #559:
Correct nodeName to clusterName as appropriate
codecov-io commented on issue #559: Correct nodeName to clusterName as appropriate
URL: https://github.com/apache/servicecomb-service-center/pull/559#issuecomment-504029744
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/559?src=pr&el=h1) Report
> Merging [#559](https://codecov.io/gh/apache/servicecomb-service-center/pull/559?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/c5a0f9f9e666791a63668bcbc84037b763986ba8?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/559?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #559 +/- ##
==========================================
+ Coverage 58.34% 58.37% +0.02%
==========================================
Files 201 201
Lines 15325 15326 +1
==========================================
+ Hits 8941 8946 +5
+ Misses 5758 5752 -6
- Partials 626 628 +2
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/559?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [syncer/servicecenter/servicecenter.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/559/diff?src=pr&el=tree#diff-c3luY2VyL3NlcnZpY2VjZW50ZXIvc2VydmljZWNlbnRlci5nbw==) | `95% <100%> (ø)` | :arrow_up: |
| [syncer/serf/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/559/diff?src=pr&el=tree#diff-c3luY2VyL3NlcmYvY29uZmlnLmdv) | `54.28% <50%> (-1.6%)` | :arrow_down: |
| [syncer/pkg/syssig/signal.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/559/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy9zeXNzaWcvc2lnbmFsLmdv) | `64.51% <0%> (-3.23%)` | :arrow_down: |
| [server/service/util/domain\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/559/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kb21haW5fdXRpbC5nbw==) | `59.7% <0%> (-1.5%)` | :arrow_down: |
| [scctl/pkg/plugin/diagnose/compare\_holder.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/559/diff?src=pr&el=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9jb21wYXJlX2hvbGRlci5nbw==) | `94.87% <0%> (-1.29%)` | :arrow_down: |
| [pkg/util/tree.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/559/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `84.37% <0%> (+3.12%)` | :arrow_up: |
| [server/notify/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/559/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS9saXN0d2F0Y2hlci5nbw==) | `79.16% <0%> (+9.72%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/559?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/559?src=pr&el=footer). Last update [c5a0f9f...d671723](https://codecov.io/gh/apache/servicecomb-service-center/pull/559?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services