You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/09/19 21:30:22 UTC
Review Request 38528: Disable perf test when perf version is not
support.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38528/
-----------------------------------------------------------
Review request for mesos, Joris Van Remoortere and Michael Park.
Bugs: MESOS-3471
https://issues.apache.org/jira/browse/MESOS-3471
Repository: mesos
Description
-------
Disable perf test when perf version is not support.
Diffs
-----
src/tests/environment.cpp e40cde23daba25b0b61b567ee73682c67e7acbdc
Diff: https://reviews.apache.org/r/38528/diff/
Testing
-------
# On CentOS 6.6
sudo make check -j8
Thanks,
haosdent huang
Re: Review Request 38528: Disable perf test when perf version is not
support.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38528/#review99686
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38528]
All tests passed.
- Mesos ReviewBot
On Sept. 19, 2015, 7:30 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38528/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2015, 7:30 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Michael Park.
>
>
> Bugs: MESOS-3471
> https://issues.apache.org/jira/browse/MESOS-3471
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Disable perf test when perf version is not support.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp e40cde23daba25b0b61b567ee73682c67e7acbdc
>
> Diff: https://reviews.apache.org/r/38528/diff/
>
>
> Testing
> -------
>
> # On CentOS 6.6
> sudo make -j8 check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38528: Disable perf test when perf version is not
support.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38528/#review99696
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38528]
All tests passed.
- Mesos ReviewBot
On Sept. 20, 2015, 2:49 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38528/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2015, 2:49 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Michael Park.
>
>
> Bugs: MESOS-3471
> https://issues.apache.org/jira/browse/MESOS-3471
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Disable perf test when perf version is not support.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp e40cde23daba25b0b61b567ee73682c67e7acbdc
>
> Diff: https://reviews.apache.org/r/38528/diff/
>
>
> Testing
> -------
>
> # On CentOS 6.6
> sudo make -j8 check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38528: Disable perf test when perf version is not
support.
Posted by haosdent huang <ha...@gmail.com>.
> On Sept. 21, 2015, 5:32 p.m., Paul Brett wrote:
> > The PerfTests ROOT_Events and ROOT_Sample both require a supported version of perf to be installed, however the Parse test does not. Could we use the supported() test to disable all events matching both ROOT and Perf?
I am not ideas. Just see a lot of failures in CentOS 6.6. Should we create a new filter, which name is "PERF_TEST_"? Also, there are not only "PerfTest.ROOT_Events" depends on "supported". I forgot 7~8 test cases is failed because of perf events, most of our cgroup test seems need perf_event.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38528/#review99773
-----------------------------------------------------------
On Sept. 21, 2015, 5:47 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38528/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 5:47 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Michael Park, and Paul Brett.
>
>
> Bugs: MESOS-3471
> https://issues.apache.org/jira/browse/MESOS-3471
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Disable perf test when perf version is not support.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp e40cde23daba25b0b61b567ee73682c67e7acbdc
>
> Diff: https://reviews.apache.org/r/38528/diff/
>
>
> Testing
> -------
>
> # On CentOS 6.6
> sudo make -j8 check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38528: Disable perf test when perf version is not
support.
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38528/#review99773
-----------------------------------------------------------
The PerfTests ROOT_Events and ROOT_Sample both require a supported version of perf to be installed, however the Parse test does not. Could we use the supported() test to disable all events matching both ROOT and Perf?
- Paul Brett
On Sept. 20, 2015, 2:49 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38528/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2015, 2:49 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Michael Park.
>
>
> Bugs: MESOS-3471
> https://issues.apache.org/jira/browse/MESOS-3471
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Disable perf test when perf version is not support.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp e40cde23daba25b0b61b567ee73682c67e7acbdc
>
> Diff: https://reviews.apache.org/r/38528/diff/
>
>
> Testing
> -------
>
> # On CentOS 6.6
> sudo make -j8 check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38528: Disable perf test when perf version is not
support.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38528/
-----------------------------------------------------------
(Updated Sept. 20, 2015, 2:49 a.m.)
Review request for mesos, Joris Van Remoortere and Michael Park.
Changes
-------
Update error messsage.
Bugs: MESOS-3471
https://issues.apache.org/jira/browse/MESOS-3471
Repository: mesos
Description
-------
Disable perf test when perf version is not support.
Diffs (updated)
-----
src/tests/environment.cpp e40cde23daba25b0b61b567ee73682c67e7acbdc
Diff: https://reviews.apache.org/r/38528/diff/
Testing
-------
# On CentOS 6.6
sudo make -j8 check
Thanks,
haosdent huang
Re: Review Request 38528: Disable perf test when perf version is not
support.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38528/
-----------------------------------------------------------
(Updated Sept. 19, 2015, 7:30 p.m.)
Review request for mesos, Joris Van Remoortere and Michael Park.
Bugs: MESOS-3471
https://issues.apache.org/jira/browse/MESOS-3471
Repository: mesos
Description
-------
Disable perf test when perf version is not support.
Diffs
-----
src/tests/environment.cpp e40cde23daba25b0b61b567ee73682c67e7acbdc
Diff: https://reviews.apache.org/r/38528/diff/
Testing (updated)
-------
# On CentOS 6.6
sudo make -j8 check
Thanks,
haosdent huang