[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35428: [SPARK-38132][SQL] Remove NotPropagation

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #35428:
URL: https://github.com/apache/spark/pull/35428#discussion_r801087830



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala
##########
@@ -1956,4 +1956,30 @@ class SubquerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
     assert(!nonDeterministicQueryPlan.deterministic)
   }
 
+  test("SPARK-38132: Avoid optimizing Not IN subquery") {

Review comment:
       Shall we give more meaningful name for this test case?
   For me, the test case looks like checking the correctness of the queries which is irrelevant to avoid `optimizing` something.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org