You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "bharath-techie (via GitHub)" <gi...@apache.org> on 2024/05/03 06:28:52 UTC
[PR] Datacube format changes to support materialized views [lucene]
bharath-techie opened a new pull request, #13342:
URL: https://github.com/apache/lucene/pull/13342
### Description
Draft PR for supporting extensions for DataCubes that mainly includes new format , changes in SegmentInfo and in indexingchain flush , SegmentMerger
<!--
If this is your first contribution to Lucene, please make sure you have reviewed the contribution guide.
https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Datacube format changes to support materialized views [lucene]
Posted by "bharath-techie (via GitHub)" <gi...@apache.org>.
bharath-techie commented on code in PR #13342:
URL: https://github.com/apache/lucene/pull/13342#discussion_r1589030697
##########
lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java:
##########
@@ -124,7 +125,8 @@ public SegmentInfo(
Map<String, String> diagnostics,
byte[] id,
Map<String, String> attributes,
- Sort indexSort) {
+ Sort indexSort,
+ DataCubesConfig dataCubesConfig) {
Review Comment:
Yeah will revert the second commit which removed the overload. I think overload is good , we can remove it if needed based on feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Datacube format changes to support materialized views [lucene]
Posted by "Bukhtawar (via GitHub)" <gi...@apache.org>.
Bukhtawar commented on code in PR #13342:
URL: https://github.com/apache/lucene/pull/13342#discussion_r1588928997
##########
lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java:
##########
@@ -124,7 +125,8 @@ public SegmentInfo(
Map<String, String> diagnostics,
byte[] id,
Map<String, String> attributes,
- Sort indexSort) {
+ Sort indexSort,
+ DataCubesConfig dataCubesConfig) {
Review Comment:
Should we overload this ctor to avoid changes across the board, unless you think this should be mandatory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org