You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/11/18 19:32:52 UTC

[GitHub] [tinkerpop] divijvaidya commented on a change in pull request #1360: TINKERPOP-2445 Parallelize connection creation

divijvaidya commented on a change in pull request #1360:
URL: https://github.com/apache/tinkerpop/pull/1360#discussion_r526365003



##########
File path: pom.xml
##########
@@ -721,6 +722,18 @@ limitations under the License.
                     </exclusion>
                 </exclusions>
             </dependency>
+            <dependency>

Review comment:
       We have two requirements here. Ability to mock a final class and use spy to mock a new initialization inside method which is being tested. Using mockito to mock final classes require using an [incubating](https://github.com/mockito/mockito/wiki/What%27s-new-in-Mockito-2#unmockable) feature in mockito. I tried using that feature but it doesn't work very nicely with spy right now. Hence, powermock is the next best option.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org