You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by kh...@apache.org on 2018/03/04 12:57:02 UTC

[maven-verifier] branch CODE_IMPROVEMENTS created (now 0266b26)

This is an automated email from the ASF dual-hosted git repository.

khmarbaise pushed a change to branch CODE_IMPROVEMENTS
in repository https://gitbox.apache.org/repos/asf/maven-verifier.git.


      at 0266b26  Code improvements.

This branch includes the following new commits:

     new 0266b26  Code improvements.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


-- 
To stop receiving notification emails like this one, please contact
khmarbaise@apache.org.

[maven-verifier] 01/01: Code improvements.

Posted by kh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

khmarbaise pushed a commit to branch CODE_IMPROVEMENTS
in repository https://gitbox.apache.org/repos/asf/maven-verifier.git

commit 0266b2674b8a1637a7e995fd87ecd502e563b7ba
Author: Karl Heinz Marbaise <kh...@apache.org>
AuthorDate: Sun Mar 4 13:56:47 2018 +0100

    Code improvements.
---
 src/main/java/org/apache/maven/it/Embedded3xLauncher.java     | 8 ++++----
 src/main/java/org/apache/maven/it/LauncherException.java      | 5 +++++
 src/main/java/org/apache/maven/it/VerificationException.java  | 5 +++++
 src/main/java/org/apache/maven/it/util/ResourceExtractor.java | 2 ++
 4 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/apache/maven/it/Embedded3xLauncher.java b/src/main/java/org/apache/maven/it/Embedded3xLauncher.java
index 67c006a..dae440d 100644
--- a/src/main/java/org/apache/maven/it/Embedded3xLauncher.java
+++ b/src/main/java/org/apache/maven/it/Embedded3xLauncher.java
@@ -93,11 +93,11 @@ class Embedded3xLauncher
 
             configure.invoke( launcher, new Object[] { new FileInputStream( config ) } );
 
-            Method getWorld = launcherClass.getMethod( "getWorld", null );
-            Object classWorld = getWorld.invoke( launcher, null );
+            Method getWorld = launcherClass.getMethod( "getWorld", (Class<?>) null );
+            Object classWorld = getWorld.invoke( launcher, (Class<?>) null );
 
-            Method getMainClass = launcherClass.getMethod( "getMainClass", null );
-            Class<?> cliClass = (Class<?>) getMainClass.invoke( launcher, null );
+            Method getMainClass = launcherClass.getMethod( "getMainClass", (Class<?>) null );
+            Class<?> cliClass = (Class<?>) getMainClass.invoke( launcher, (Class<?>) null );
 
             Constructor<?> newMavenCli = cliClass.getConstructor( new Class[] { classWorld.getClass() } );
             Object mavenCli = newMavenCli.newInstance( new Object[] { classWorld } );
diff --git a/src/main/java/org/apache/maven/it/LauncherException.java b/src/main/java/org/apache/maven/it/LauncherException.java
index 76db37e..d31d1d1 100644
--- a/src/main/java/org/apache/maven/it/LauncherException.java
+++ b/src/main/java/org/apache/maven/it/LauncherException.java
@@ -26,6 +26,11 @@ class LauncherException
     extends Exception
 {
 
+    /**
+     * 
+     */
+    private static final long serialVersionUID = 1L;
+
     public LauncherException( String message )
     {
         super( message );
diff --git a/src/main/java/org/apache/maven/it/VerificationException.java b/src/main/java/org/apache/maven/it/VerificationException.java
index cd81448..e014488 100644
--- a/src/main/java/org/apache/maven/it/VerificationException.java
+++ b/src/main/java/org/apache/maven/it/VerificationException.java
@@ -26,6 +26,11 @@ package org.apache.maven.it;
 public class VerificationException
     extends Exception
 {
+    /**
+     * 
+     */
+    private static final long serialVersionUID = 1L;
+
     public VerificationException()
     {
     }
diff --git a/src/main/java/org/apache/maven/it/util/ResourceExtractor.java b/src/main/java/org/apache/maven/it/util/ResourceExtractor.java
index 5ea6330..d2913b7 100644
--- a/src/main/java/org/apache/maven/it/util/ResourceExtractor.java
+++ b/src/main/java/org/apache/maven/it/util/ResourceExtractor.java
@@ -141,6 +141,7 @@ public class ResourceExtractor
                         finally
                         {
                             IOUtil.close( fos );
+                            z.close();
                         }
                     }
                 }
@@ -156,6 +157,7 @@ public class ResourceExtractor
             finally
             {
                 IOUtil.close( fos );
+                z.close();
             }
         }
     }

-- 
To stop receiving notification emails like this one, please contact
khmarbaise@apache.org.