You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "pedro-w (via GitHub)" <gi...@apache.org> on 2023/03/07 11:28:26 UTC
[GitHub] [netbeans-native-installers] pedro-w opened a new pull request, #4: Make installer also look for Java on the PATH
pedro-w opened a new pull request, #4:
URL: https://github.com/apache/netbeans-native-installers/pull/4
This is an attempt to fix [Issue 5060](https://github.com/apache/netbeans/issues/5060)
This PR also
* Modifies the Makefile to separate out the flags, source files etc. and make it only recompile where needed
* Fixes all warnings from `-W` and `-Wall` from MinGW (i.e. gcc)
then adds a routine to look for a JDK, where with the JDK's bin directory is on the PATH. In my case I installed Adoptium without modifying the registry and therefore the native installer couldn't find it (see bug report)
This PR also builds upon the changes in #3 which is yet to be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-native-installers] pedro-w commented on pull request #4: Make installer also look for Java on the PATH
Posted by "pedro-w (via GitHub)" <gi...@apache.org>.
pedro-w commented on PR #4:
URL: https://github.com/apache/netbeans-native-installers/pull/4#issuecomment-1466581790
Hi, yes I will do that.
On Mon, 13 Mar 2023 at 16:55, Eric Barboni ***@***.***> wrote:
> hi @pedro-w <https://github.com/pedro-w> you will need to sync the PR to
> the changes.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/netbeans-native-installers/pull/4#issuecomment-1466524474>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AFJFGZYBAXTFL2JGVCV4ALDW35GQ7ANCNFSM6AAAAAAVSLCE7Y>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-native-installers] ebarboni commented on pull request #4: Make installer also look for Java on the PATH
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #4:
URL: https://github.com/apache/netbeans-native-installers/pull/4#issuecomment-1471580351
some conflict are present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-native-installers] ebarboni merged pull request #4: Make installer also look for Java on the PATH
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni merged PR #4:
URL: https://github.com/apache/netbeans-native-installers/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-native-installers] pedro-w commented on pull request #4: Make installer also look for Java on the PATH
Posted by "pedro-w (via GitHub)" <gi...@apache.org>.
pedro-w commented on PR #4:
URL: https://github.com/apache/netbeans-native-installers/pull/4#issuecomment-1471619662
> some conflict are present.
Aiee! It was OK until I pushed something one hour ago... should be right again now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-native-installers] ebarboni commented on pull request #4: Make installer also look for Java on the PATH
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #4:
URL: https://github.com/apache/netbeans-native-installers/pull/4#issuecomment-1466524474
hi @pedro-w you will need to sync the PR to the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-native-installers] pedro-w commented on pull request #4: Make installer also look for Java on the PATH
Posted by "pedro-w (via GitHub)" <gi...@apache.org>.
pedro-w commented on PR #4:
URL: https://github.com/apache/netbeans-native-installers/pull/4#issuecomment-1469439072
@ebarboni it's ready for you to have a look at when you've got time, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-native-installers] ebarboni commented on pull request #4: Make installer also look for Java on the PATH
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #4:
URL: https://github.com/apache/netbeans-native-installers/pull/4#issuecomment-1472296945
looks good for me. I guess to get it in NetBeans will be hard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-native-installers] pedro-w commented on pull request #4: Make installer also look for Java on the PATH
Posted by "pedro-w (via GitHub)" <gi...@apache.org>.
pedro-w commented on PR #4:
URL: https://github.com/apache/netbeans-native-installers/pull/4#issuecomment-1472327006
> looks good for me. I guess to get it in NetBeans will be hard.
I think so too. I did some work on the profiler (also native windows code) a while back and I had given up on it, before someone else tidied it up and merged it about a year later https://github.com/apache/netbeans/pull/2021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists