You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/02 08:47:00 UTC

[jira] [Commented] (FLINK-8549) Move TimerServiceOptions to TaskManagerOptions

    [ https://issues.apache.org/jira/browse/FLINK-8549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349989#comment-16349989 ] 

ASF GitHub Bot commented on FLINK-8549:
---------------------------------------

GitHub user StephanEwen opened a pull request:

    https://github.com/apache/flink/pull/5402

    [FLINK-8549] [config] Move TimerServiceOptions into TaskManagerOptions

    The `TimerServiceOptions` are in the wrong place, which prohibits generation of config docs. It also cause over-fragmentation of the options in the code base.
    
    This PR moves the one option from that class to the `TaskManagerOptions`, as it relates to task execution. Other shutdown related options are in there already.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StephanEwen/incubator-flink timer_service_options

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5402.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5402
    
----
commit f5045b211ce95a41fe1c6f77fdeacbe57f930c8e
Author: Stephan Ewen <se...@...>
Date:   2018-02-02T08:38:37Z

    [FLINK-8549] [config] Move TimerServiceOptions into TaskManagerOptions

----


> Move TimerServiceOptions to TaskManagerOptions
> ----------------------------------------------
>
>                 Key: FLINK-8549
>                 URL: https://issues.apache.org/jira/browse/FLINK-8549
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>            Priority: Major
>             Fix For: 1.5.0
>
>
> The {{TimerServiceOptions}} are in the wrong place (prohibit generation of config docs) and cause over-fragmentation of the options in the code base.
> I propose to simple move the one option from that class to the {{TaskManagerOptions}}, as it relates to task execution. Other shutdown related options are in there already.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)