You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "CRZbulabula (via GitHub)" <gi...@apache.org> on 2026/06/16 07:15:47 UTC
[PR] Fix per-database region allocation IT timeout [iotdb]
CRZbulabula opened a new pull request, #17950:
URL: https://github.com/apache/iotdb/pull/17950
## Description
This patch fixes a flaky timeout in `IoTDBPerDatabaseRegionGroupAllocationIT` when creating DataRegionGroups with the GCR allocation policy.
The test only validates DataRegion replica placement, but it disabled IoTConsensus leader balancing. With leader balancing disabled, newly created IoTConsensus DataRegionGroups can remain with `leaderId=-1` until `CreateRegionGroupsProcedure` waits close to the procedure timeout. Under GCR, region creation may take long enough for the outer procedure wait to time out and return `CREATE_REGION_ERROR` even though all replicas were created successfully.
Enable IoTConsensus leader balancing for this replica-placement test so RegionGroups become ready promptly, without changing replica placement assertions.
The assertion for DataPartition creation now also includes the returned TSStatus for easier diagnosis.
## Tests
- `mvn spotless:apply -pl integration-test -P with-integration-tests`
- `mvn verify -Drat.skip=true -DskipUTs -Dit.test=IoTDBPerDatabaseRegionGroupAllocationIT -DfailIfNoTests=false -Dfailsafe.failIfNoSpecifiedTests=false -pl integration-test -am -PClusterIT -P with-integration-tests`
Note: local full RAT validation was blocked by an unrelated `.claude/scheduled_tasks.lock` file in the working tree, so the focused IT verification used `-Drat.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove IoTConsensus auto leader balance toggle [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #17950:
URL: https://github.com/apache/iotdb/pull/17950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove IoTConsensus auto leader balance toggle [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #17950:
URL: https://github.com/apache/iotdb/pull/17950#issuecomment-4716527131
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/17950?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `33.33333%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 41.15%. Comparing base ([`8fad784`](https://app.codecov.io/gh/apache/iotdb/commit/8fad78466f6e72930c140aed43a856674f10d2cb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`dc4493b`](https://app.codecov.io/gh/apache/iotdb/commit/dc4493b84af4927c9f0f6c8515fe0c56f01e1a17?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/17950?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...onfignode/manager/load/balancer/RouteBalancer.java](https://app.codecov.io/gh/apache/iotdb/pull/17950?src=pr&el=tree&filepath=iotdb-core%2Fconfignode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fconfignode%2Fmanager%2Fload%2Fbalancer%2FRouteBalancer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25maWdub2RlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pb3RkYi9jb25maWdub2RlL21hbmFnZXIvbG9hZC9iYWxhbmNlci9Sb3V0ZUJhbGFuY2VyLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/17950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17950 +/- ##
============================================
- Coverage 41.15% 41.15% -0.01%
Complexity 318 318
============================================
Files 5258 5258
Lines 365613 365602 -11
Branches 47282 47279 -3
============================================
- Hits 150460 150451 -9
+ Misses 215153 215151 -2
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/iotdb/pull/17950?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove IoTConsensus auto leader balance toggle [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17950:
URL: https://github.com/apache/iotdb/pull/17950#issuecomment-4716272628
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17950) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=17950&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=17950&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=17950&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=17950&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=17950&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17950)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix per-database region allocation IT timeout [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17950:
URL: https://github.com/apache/iotdb/pull/17950#issuecomment-4715985535
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17950) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=17950&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=17950&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=17950&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=17950&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=17950&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17950)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org