You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/05/05 17:44:01 UTC
[jira] [Commented] (FLINK-1974) JobExecutionResult NetRuntime -
document result type
[ https://issues.apache.org/jira/browse/FLINK-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528685#comment-14528685 ]
ASF GitHub Bot commented on FLINK-1974:
---------------------------------------
GitHub user jkirsch opened a pull request:
https://github.com/apache/flink/pull/652
[FLINK-1974] JobExecutionResult NetRuntime - document result type
- Added documentation to indicate that the return type is in milliseconds
- Added an elapsedNetRuntime method which accepts a desired time unit for easy conversion
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkirsch/incubator-flink JobExecutionResult
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/652.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #652
----
commit ea909b5298828851149e5a087a03dffcf0a09fca
Author: Johannes <jk...@gmail.com>
Date: 2015-05-05T15:32:41Z
[FLINK-1974] JobExecutionResult NetRuntime - document result type
- Added documentation to indicate that the return type is in milliseconds
- Added an elapsedNetRuntime method which accepts a desired time unit for easy conversion
----
> JobExecutionResult NetRuntime - document result type
> ----------------------------------------------------
>
> Key: FLINK-1974
> URL: https://issues.apache.org/jira/browse/FLINK-1974
> Project: Flink
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 0.9
> Environment: The JobExecutionResult stores the net execution times in milliseconds, but does not say so.
> A simple fix is to add it to the JavaDoc .. a more complete fix would be to change the method name to getNetRuntimeMs or even use an auto conversion, such as getElapsedNetRuntime(Timeunit) which would autoconvert
> Reporter: Johannes
> Assignee: Johannes
> Priority: Trivial
> Labels: easyfix
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)