You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mattyb149 <gi...@git.apache.org> on 2017/04/11 16:09:05 UTC
[GitHub] nifi pull request #1664: NIFI-2323: Fixed Oracle timestamp handling in DB fe...
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/1664
NIFI-2323: Fixed Oracle timestamp handling in DB fetch processors
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-2323
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1664.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1664
----
commit 5d163b7061e4d12269db7c514fa15052df4553ad
Author: Matt Burgess <ma...@apache.org>
Date: 2017-04-11T16:00:31Z
NIFI-2323: Fixed Oracle timestamp handling in DB fetch processors
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1664: NIFI-2323: Fixed Oracle timestamp handling in DB fe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1664
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1664: NIFI-2323: Fixed Oracle timestamp handling in DB fetch pro...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1664
This looks good to me. Code is clean and makes sense. Contrib-check passes with all unit tests. +1 merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1664: NIFI-2323: Fixed Oracle timestamp handling in DB fe...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1664#discussion_r111008309
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractDatabaseFetchProcessor.java ---
@@ -413,7 +400,7 @@ protected static String getLiteralByType(int type, String value, String database
case TIMESTAMP:
// Timestamp literals in Oracle need to be cast with TO_DATE
if ("Oracle".equals(databaseType)) {
- return "to_date('" + value + "', 'yyyy-mm-dd HH24:MI:SS')";
+ return "timestamp '" + value + "'";
--- End diff --
This probably breaks backwards compatibility if the processor has already stored a Date (no time-of-day) into the StateMap. To preserve backwards compatibility, we should check if the value is just a Date and use the "date" coercion instead of the "timestamp" coercion. If that succeeds, then the next maximum value observed should be stored as a full timestamp and the "date" coercion should no longer be executed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---