You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/20 01:10:46 UTC

[GitHub] [skywalking-satellite] EvanLjp commented on a change in pull request #27: polish codes for release & add performance test doc

EvanLjp commented on a change in pull request #27:
URL: https://github.com/apache/skywalking-satellite/pull/27#discussion_r579563610



##########
File path: Makefile
##########
@@ -73,11 +75,16 @@ clean: tools
 	-rm -rf coverage.txt
 
 .PHONY: build
-build: clean deps linux darwin windows
+build: clean deps
+	rm -rf bin/*

Review comment:
       In the local test ， I build some different version docker images and push them to a private repository. Because of using the find command in the start script， the docker started failed when having history file. If needed to the original version, I would rollback it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org