[jira] [Commented] (MYNEWT-741) Port of LoRaMac-node library

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MYNEWT-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989634#comment-15989634 ] 

ASF subversion and git services commented on MYNEWT-741:
--------------------------------------------------------

Commit 560fa9206904948bff567ab980c8a94ea064d65c in incubator-mynewt-core's branch refs/heads/master from [~ccollins476]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-mynewt-core.git;h=560fa92 ]

MYNEWT-741 Port of LoRaMac-node library

Implement suggested changed from code review:

1. Replace hardcoded 0 argument to hal_spi_enable(); use syscfg setting
   instead.
2. Merge hw/drivers/lora/node/{radio,board} --> hw/drivers/lora
3. Default LoRa SPI index to -1; require BSP to override this setting
   with an actual value.

Regarding 2: the purpose of the "node" subdirectory was to distinguish
this code from a potential gateway implementation.  This subdirectory
remains in the net/lora directory (mirroring
net/nimble/{host,controller}), but it has been removed from the driver
directory tree.  Presumably, end-device vs. gateway drivers use
different hardware, and will be distinguishable by their package name.


> Port of LoRaMac-node library
> ----------------------------
>
>                 Key: MYNEWT-741
>                 URL: https://issues.apache.org/jira/browse/MYNEWT-741
>             Project: Mynewt
>          Issue Type: New Feature
>            Reporter: Christopher Collins
>            Assignee: Christopher Collins
>             Fix For: v1_1_0_rel
>
>
> Port Semtech's LoRaMac-node library (https://github.com/Lora-net/LoRaMac-node) to Mynewt.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)