[GitHub] [beam] aromanenko-dev commented on a change in pull request #10078: [BEAM-8542] Change write to async in AWS SNS IO & remove retry logic

[GitBox <gi...@apache.org>]

aromanenko-dev commented on a change in pull request #10078:
URL: https://github.com/apache/beam/pull/10078#discussion_r419578585



##########
File path: sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/sns/SnsIO.java
##########
@@ -504,18 +504,18 @@ public void tearDown() {
       checkArgument(getCoder() != null, "withElementCoder() needs to called");
 
       return input
-          .apply(ParDo.of(new SnsAsyncWriterFn<>(this)))
+          .apply(ParDo.of(new SnsWriteAsyncrFn<>(this)))
           .setCoder(SnsResponseCoder.of(getCoder()));
     }
 
-    private static class SnsAsyncWriterFn<T> extends DoFn<T, SnsResponse<T>> {
+    private static class SnsWriteAsyncrFn<T> extends DoFn<T, SnsResponse<T>> {
 
-      private static final Logger LOG = LoggerFactory.getLogger(SnsAsyncWriterFn.class);
+      private static final Logger LOG = LoggerFactory.getLogger(SnsWriteAsyncrFn.class);
 
-      private final AsyncWrite<T> spec;
+      private final WriteAsync<T> spec;
       private transient SnsAsyncClient client;
 
-      SnsAsyncWriterFn(AsyncWrite<T> spec) {
+      SnsWriteAsyncrFn(WriteAsync<T> spec) {

Review comment:
       nit: `SnsWriteAsyncrFn` - I guess a letter "r" before "Fn" is redundant. Please remove it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org