You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/28 19:13:21 UTC

[GitHub] [arrow] nealrichardson opened a new pull request #9034: ARROW-10733: [R] Improvements to Linux installation troubleshooting

nealrichardson opened a new pull request #9034:
URL: https://github.com/apache/arrow/pull/9034


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jonkeane commented on a change in pull request #9034: ARROW-10733: [R] Improvements to Linux installation troubleshooting

Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #9034:
URL: https://github.com/apache/arrow/pull/9034#discussion_r549924781



##########
File path: r/vignettes/install.Rmd
##########
@@ -286,12 +291,12 @@ so that we can attempt to improve the script.
 * On CentOS, if you are using a more modern `devtoolset`, you may need to set
 the environment variables `CC` and `CXX` either in the shell or in R's `Makeconf`.
 For CentOS 7 and above, both the Arrow system packages and the C++ binaries
-for R are built with the default system compilers. If you want to use either of these 
-and you have a `devtoolset` installed, set `CC=/usr/bin/gcc CXX=/usr/bin/g++` 
-to use the system compilers instead of the `devtoolset`. 
-Alternatively, if you want to build `arrow` with the newer `devtoolset` compilers, 
+for R are built with the default system compilers. If you want to use either of these
+and you have a `devtoolset` installed, set `CC=/usr/bin/gcc CXX=/usr/bin/g++`
+to use the system compilers instead of the `devtoolset`.
+Alternatively, if you want to build `arrow` with the newer `devtoolset` compilers,

Review comment:
       👍 this all looks good and matches what I was experiencing on centos




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nealrichardson commented on a change in pull request #9034: ARROW-10733: [R] Improvements to Linux installation troubleshooting

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #9034:
URL: https://github.com/apache/arrow/pull/9034#discussion_r550251046



##########
File path: r/vignettes/install.Rmd
##########
@@ -175,25 +181,24 @@ tune one of several parameters. Here are some known complications and ways to ad
 If you get an error like
 
 ```
-Cannot call io___MemoryMappedFile__Open(). Please use arrow::install_arrow() to install required runtime libraries.
+Cannot call io___MemoryMappedFile__Open(). See https://arrow.apache.org/docs/r/articles/install.html for help installing Arrow C++ libraries.
 ```
 
 for every `arrow` function you call,
 that means that installing the package failed to retrieve or build C++ libraries
-compatible with the current version of the R package. `install_arrow()` provides
-some convenience wrappers around the various environment variables described below
-and has defaults that should isolate the package installation and make it
-more likely to succeed. See its help page for details.
-
-As of version 0.17, it is expected that C++ dependencies should be built successfully
-on all Linux distributions, so if you see this message because the C++ libraries
-errored while building,
+compatible with the current version of the R package.
+
+It is expected that C++ dependencies should be built successfully
+on all Linux distributions, so you should not see this message. If you do,
+please check the "Known installation issues" below to see if any apply.
+If none apply, retry the installation with `arrow::install_arrow(verbose = TRUE)`
+so that details on what failed are shown, then
 please [report an issue](https://issues.apache.org/jira/projects/ARROW/issues).

Review comment:
       Yeah the first ask is almost always to rerun with verbosity (what I added in this PR) and share the logs. Probably would be good to explicitly ask for the full output here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jonkeane commented on a change in pull request #9034: ARROW-10733: [R] Improvements to Linux installation troubleshooting

Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #9034:
URL: https://github.com/apache/arrow/pull/9034#discussion_r549924720



##########
File path: r/vignettes/install.Rmd
##########
@@ -175,25 +181,24 @@ tune one of several parameters. Here are some known complications and ways to ad
 If you get an error like
 
 ```
-Cannot call io___MemoryMappedFile__Open(). Please use arrow::install_arrow() to install required runtime libraries.
+Cannot call io___MemoryMappedFile__Open(). See https://arrow.apache.org/docs/r/articles/install.html for help installing Arrow C++ libraries.
 ```
 
 for every `arrow` function you call,
 that means that installing the package failed to retrieve or build C++ libraries
-compatible with the current version of the R package. `install_arrow()` provides
-some convenience wrappers around the various environment variables described below
-and has defaults that should isolate the package installation and make it
-more likely to succeed. See its help page for details.
-
-As of version 0.17, it is expected that C++ dependencies should be built successfully
-on all Linux distributions, so if you see this message because the C++ libraries
-errored while building,
+compatible with the current version of the R package.
+
+It is expected that C++ dependencies should be built successfully
+on all Linux distributions, so you should not see this message. If you do,
+please check the "Known installation issues" below to see if any apply.
+If none apply, retry the installation with `arrow::install_arrow(verbose = TRUE)`
+so that details on what failed are shown, then
 please [report an issue](https://issues.apache.org/jira/projects/ARROW/issues).

Review comment:
       Do we want to proactively ask for the install log in the report? I've seen a few jiras where that's usually the first ask.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #9034: ARROW-10733: [R] Improvements to Linux installation troubleshooting

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9034:
URL: https://github.com/apache/arrow/pull/9034#issuecomment-751835466


   https://issues.apache.org/jira/browse/ARROW-10733


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nealrichardson closed pull request #9034: ARROW-10733: [R] Improvements to Linux installation troubleshooting

Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #9034:
URL: https://github.com/apache/arrow/pull/9034


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jonkeane commented on pull request #9034: ARROW-10733: [R] Improvements to Linux installation troubleshooting

Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #9034:
URL: https://github.com/apache/arrow/pull/9034#issuecomment-752317119


   This looks good, one minor addition/comment.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nealrichardson commented on pull request #9034: ARROW-10733: [R] Improvements to Linux installation troubleshooting

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #9034:
URL: https://github.com/apache/arrow/pull/9034#issuecomment-752152634


   Passing builds on my fork: https://github.com/nealrichardson/arrow/actions/runs/449373084


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org