[jira] [Commented] (SLING-5828) Support multi-valued Constants.SERVICE_PID

["Carsten Ziegeler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367537#comment-15367537 ] 

Carsten Ziegeler commented on SLING-5828:
-----------------------------------------

I think in general, replacing SERVICE_PID - which is not really reliable - with SERVICE_ID is the best option. But I guess we have to carefully look into the different use cases

> Support multi-valued Constants.SERVICE_PID
> ------------------------------------------
>
>                 Key: SLING-5828
>                 URL: https://issues.apache.org/jira/browse/SLING-5828
>             Project: Sling
>          Issue Type: Bug
>          Components: General
>            Reporter: Bertrand Delacretaz
>            Priority: Minor
>         Attachments: string-pid.txt
>
>
> As shown by SLING-5827 it is possible for the Constants.SERVICE_PID property of an OSGi service to be an array or a Collection of String.
> Quoting [1], _The value of this property must be of type String, String[], or Collection of String_.
> We have several places in our code that assume the value to be just a String, I'll attach an initial list and confirm on our dev list that we need to fix them.
> [1] https://osgi.org/javadoc/r4v43/core/org/osgi/framework/Constants.html#SERVICE_PID



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)