You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "123123213weqw (via GitHub)" <gi...@apache.org> on 2026/10/19 10:33:33 UTC
[PR] fix(metrics): cancel obsolete fallback timers when the explorer scope changes [rocketmq-dashboard]
123123213weqw opened a new pull request, #7054:
URL: https://github.com/apache/rocketmq-dashboard/pull/7054
Fixes #6462.
The MetricsExplorer scope-fallback effect scheduled its data-source reset through a zero-delay `window.setTimeout` whose id was never captured, so the pending callback survived effect cleanup — an unmount, or the scope changing away and back before the timer ran, still reset the source/credentials and re-issued queries under the abandoned scope.
The timer id is now captured and cleared by the effect's cleanup: any re-run (scope change) or unmount cancels the pending fallback, while the intended fallback (leaving the instance scope with no selection) is unchanged.
Two red-first component regressions: unmount before the timer executes produces no reset and no extra query, and leaving-then-returning before it executes keeps the restored source selected with the reload routed through the original instance's data source — both fail on the old code. Suite is 54/54.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metrics): cancel obsolete fallback timers when the explorer scope changes [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7054:
URL: https://github.com/apache/rocketmq-dashboard/pull/7054#issuecomment-6512119236
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metrics): cancel obsolete fallback timers when the explorer scope changes [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #7054: fix(metrics): cancel obsolete fallback timers when the explorer scope changes
URL: https://github.com/apache/rocketmq-dashboard/pull/7054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org