[flink-statefun] 15/17: [FLINK-17533] Remove concurrent checkpoints limitation

[tz...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

tzulitai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink-statefun.git

commit 6425f42d9a62ce3185f0fd3eb284a5756f992445
Author: Igal Shilman <ig...@gmail.com>
AuthorDate: Tue May 5 23:03:36 2020 +0200

    [FLINK-17533] Remove concurrent checkpoints limitation
    
    This closes #105.
---
 docs/deployment-and-operations/packaging.md                  |  1 -
 .../flink/core/StatefulFunctionsConfigValidator.java         | 12 ------------
 .../docker/flink-distribution-template/conf/flink-conf.yaml  |  1 -
 3 files changed, 14 deletions(-)

diff --git a/docs/deployment-and-operations/packaging.md b/docs/deployment-and-operations/packaging.md
index d603920..7af18f1 100644
--- a/docs/deployment-and-operations/packaging.md
+++ b/docs/deployment-and-operations/packaging.md
@@ -73,6 +73,5 @@ The following configurations are strictly required for running StateFun applicat
 
 {% highlight yaml %}
 classloader.parent-first-patterns.additional: org.apache.flink.statefun;org.apache.kafka;com.google.protobuf
-execution.checkpointing.max-concurrent-checkpoints: 1
 {% endhighlight %}
 
diff --git a/statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/StatefulFunctionsConfigValidator.java b/statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/StatefulFunctionsConfigValidator.java
index 9a7b0d1..c4f658c 100644
--- a/statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/StatefulFunctionsConfigValidator.java
+++ b/statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/StatefulFunctionsConfigValidator.java
@@ -27,7 +27,6 @@ import java.util.Set;
 import org.apache.flink.configuration.Configuration;
 import org.apache.flink.configuration.CoreOptions;
 import org.apache.flink.statefun.flink.core.exceptions.StatefulFunctionsInvalidConfigException;
-import org.apache.flink.streaming.api.environment.ExecutionCheckpointingOptions;
 
 public final class StatefulFunctionsConfigValidator {
 
@@ -41,7 +40,6 @@ public final class StatefulFunctionsConfigValidator {
 
   static void validate(Configuration configuration) {
     validateParentFirstClassloaderPatterns(configuration);
-    validateMaxConcurrentCheckpoints(configuration);
   }
 
   private static void validateParentFirstClassloaderPatterns(Configuration configuration) {
@@ -54,16 +52,6 @@ public final class StatefulFunctionsConfigValidator {
     }
   }
 
-  private static void validateMaxConcurrentCheckpoints(Configuration configuration) {
-    final int maxConcurrentCheckpoints =
-        configuration.get(ExecutionCheckpointingOptions.MAX_CONCURRENT_CHECKPOINTS);
-    if (maxConcurrentCheckpoints != 1) {
-      throw new StatefulFunctionsInvalidConfigException(
-          ExecutionCheckpointingOptions.MAX_CONCURRENT_CHECKPOINTS,
-          "Value must be 1, Stateful Functions does not support concurrent checkpoints.");
-    }
-  }
-
   private static Set<String> parentFirstClassloaderPatterns(Configuration configuration) {
     final String[] split =
         configuration.get(CoreOptions.ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL).split(";");
diff --git a/tools/docker/flink-distribution-template/conf/flink-conf.yaml b/tools/docker/flink-distribution-template/conf/flink-conf.yaml
index d0d4522..430c4cb 100644
--- a/tools/docker/flink-distribution-template/conf/flink-conf.yaml
+++ b/tools/docker/flink-distribution-template/conf/flink-conf.yaml
@@ -19,7 +19,6 @@
 #==============================================================================
 
 classloader.parent-first-patterns.additional: org.apache.flink.statefun;org.apache.kafka;com.google.protobuf
-execution.checkpointing.max-concurrent-checkpoints: 1
 
 #==============================================================================
 # Recommended configurations. Users may change according to their needs.