[GitHub] [maven] jmax01 commented on a change in pull request #422: MNG-6727 Check for ${project.version} not ${ when parent has a version range

[GitBox <gi...@apache.org>]

jmax01 commented on a change in pull request #422:
URL: https://github.com/apache/maven/pull/422#discussion_r549882027



##########
File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##########
@@ -1200,7 +1200,7 @@ public ModelSource getModelSource()
                 }
                 else
                 {
-                    if ( childModel.getVersion().contains( "${" ) )
+                    if ( childModel.getVersion().contains( "${project.version}" ) )

Review comment:
       Should be and I should have committed the test fix the dang test (which I am doing now) sorry!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org