You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2021/06/30 19:34:07 UTC

[GitHub] [myfaces] melloware opened a new pull request #220: Normalize files based on .gitattributes

melloware opened a new pull request #220:
URL: https://github.com/apache/myfaces/pull/220


   This normalizes all files in master using `git add --renormalize .`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [myfaces] melloware commented on pull request #220: Normalize files based on .gitattributes

Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #220:
URL: https://github.com/apache/myfaces/pull/220#issuecomment-907632108


   @volosied can you run `git add --renormalize .` on your local setup and see what it says needs to be fixed?  To compare it to mine?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [myfaces] melloware commented on pull request #220: Normalize files based on .gitattributes

Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #220:
URL: https://github.com/apache/myfaces/pull/220#issuecomment-876778865


   Just run `git add --renormalize .` on your codebase.  That basically runs through all files making they match gitattributes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [myfaces] volosied commented on pull request #220: Normalize files based on .gitattributes

Posted by GitBox <gi...@apache.org>.
volosied commented on pull request #220:
URL: https://github.com/apache/myfaces/pull/220#issuecomment-907671223


   I'm seeing 48 files as well.  They all appear to match those in your PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [myfaces] volosied edited a comment on pull request #220: Normalize files based on .gitattributes

Posted by GitBox <gi...@apache.org>.
volosied edited a comment on pull request #220:
URL: https://github.com/apache/myfaces/pull/220#issuecomment-876725394


   Sorry for creating a conflict. If you could rebase, I'll approve.  
   
   I encountered this myself with my recent PR.  
   
   Edit: Hmm. 52 seems like a lot 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [myfaces] volosied commented on pull request #220: Normalize files based on .gitattributes

Posted by GitBox <gi...@apache.org>.
volosied commented on pull request #220:
URL: https://github.com/apache/myfaces/pull/220#issuecomment-876725394


   Sorry for creating a conflict. If you could rebase, I'll approve. 
   
   I encountered this myself with my recent PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [myfaces] volosied commented on pull request #220: Normalize files based on .gitattributes

Posted by GitBox <gi...@apache.org>.
volosied commented on pull request #220:
URL: https://github.com/apache/myfaces/pull/220#issuecomment-907671386


   Rebase & Merge? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [myfaces] tandraschko merged pull request #220: Normalize files based on .gitattributes

Posted by GitBox <gi...@apache.org>.
tandraschko merged pull request #220:
URL: https://github.com/apache/myfaces/pull/220


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org