You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/02 18:32:48 UTC

[GitHub] [pulsar-helm-chart] rvashishth opened a new pull request #37: add targetport for grafana nad manager service

rvashishth opened a new pull request #37:
URL: https://github.com/apache/pulsar-helm-chart/pull/37


   ### Motivation
   
   A [Kubernetes service](https://kubernetes.io/docs/concepts/services-networking/service/) can map any incoming port to a targetPort. By default and for convenience, the targetPort is set to the same value as the port field.
   
   This change will give the flexibility to change targetPort without customizing the chart templates.
   
   ### Modifications
   
   - move port under service in values file
   - add targetPort for grafana and pulsar_manager service
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] sijie merged pull request #37: add targetport for grafana and manager service

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #37:
URL: https://github.com/apache/pulsar-helm-chart/pull/37


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] rvashishth commented on a change in pull request #37: add targetport for grafana and manager service

Posted by GitBox <gi...@apache.org>.
rvashishth commented on a change in pull request #37:
URL: https://github.com/apache/pulsar-helm-chart/pull/37#discussion_r449200368



##########
File path: charts/pulsar/values.yaml
##########
@@ -813,6 +812,8 @@ grafana:
   ##
   service:
     type: LoadBalancer
+    port: 3000

Review comment:
       as the port is for service mapping, it would be more suitable to keep it under service section. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org