You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hivemall.apache.org by Makoto Yui <my...@apache.org> on 2016/12/05 06:15:31 UTC
Contribution guideline
I'm considering the following steps for Hivemall contribution procedure:
1). fork ASF mirror https://github.com/apache/incubator-hivemall
2). work on local branch (hotfix/xxx, JIRA-xxx)
better to create a JIRA issue if the pull requests is not a hotfix
Pull request need to be linked to a JIRA issue
3). create pull request to the master branch of
https://github.com/apache/incubator-hivemall
4). review on github pull requests
5). merge (-squash) on the master branch and push to ASF git
repository (by committer's role)
I'll update the contribution guide and make it more simple one.
> Kai,
So, do not push branches to ASF repository.
Initial migrated branches are exceptional ones.
Better to keep ASF git repository clean.
Thanks,
Makoto
Re: Contribution guideline
Posted by Kai Sasaki <sa...@treasure-data.com>.
JFYI
I found some branch can be deleted by asf-git bot automatically.
https://github.com/apache/incubator-hivemall/pull/8 <https://github.com/apache/incubator-hivemall/pull/8>
They might be deleted by closing automatically, though I’m not sure the condition.
Kai
> On 2016 Dec 5, at 15:58, Makoto Yui <yu...@gmail.com> wrote:
>
> It seems we cannot delete repository from ASF git mirror (github).
> https://github.com/apache/incubator-hivemall/tree/remove-migrating-repo-alert
>
> I already removed it from
> https://git-wip-us.apache.org/repos/asf/incubator-hivemall.git though.
>
> It means that incorrectly imported files (e.g., passwords) never be deleted..
> Committers need to be aware of that.
>
> Do not push branches to
> https://git-wip-us.apache.org/repos/asf/incubator-hivemall.git
>
> Makoto
>
> 2016-12-05 15:15 GMT+09:00 Makoto Yui <my...@apache.org>:
>> I'm considering the following steps for Hivemall contribution procedure:
>>
>> 1). fork ASF mirror https://github.com/apache/incubator-hivemall
>> 2). work on local branch (hotfix/xxx, JIRA-xxx)
>> better to create a JIRA issue if the pull requests is not a hotfix
>> Pull request need to be linked to a JIRA issue
>> 3). create pull request to the master branch of
>> https://github.com/apache/incubator-hivemall
>> 4). review on github pull requests
>> 5). merge (-squash) on the master branch and push to ASF git
>> repository (by committer's role)
>>
>> I'll update the contribution guide and make it more simple one.
>>
>>> Kai,
>> So, do not push branches to ASF repository.
>> Initial migrated branches are exceptional ones.
>>
>> Better to keep ASF git repository clean.
>>
>> Thanks,
>> Makoto
Re: Contribution guideline
Posted by Makoto Yui <yu...@gmail.com>.
It seems we cannot delete repository from ASF git mirror (github).
https://github.com/apache/incubator-hivemall/tree/remove-migrating-repo-alert
I already removed it from
https://git-wip-us.apache.org/repos/asf/incubator-hivemall.git though.
It means that incorrectly imported files (e.g., passwords) never be deleted..
Committers need to be aware of that.
Do not push branches to
https://git-wip-us.apache.org/repos/asf/incubator-hivemall.git
Makoto
2016-12-05 15:15 GMT+09:00 Makoto Yui <my...@apache.org>:
> I'm considering the following steps for Hivemall contribution procedure:
>
> 1). fork ASF mirror https://github.com/apache/incubator-hivemall
> 2). work on local branch (hotfix/xxx, JIRA-xxx)
> better to create a JIRA issue if the pull requests is not a hotfix
> Pull request need to be linked to a JIRA issue
> 3). create pull request to the master branch of
> https://github.com/apache/incubator-hivemall
> 4). review on github pull requests
> 5). merge (-squash) on the master branch and push to ASF git
> repository (by committer's role)
>
> I'll update the contribution guide and make it more simple one.
>
>> Kai,
> So, do not push branches to ASF repository.
> Initial migrated branches are exceptional ones.
>
> Better to keep ASF git repository clean.
>
> Thanks,
> Makoto
Re: Contribution guideline
Posted by Takeshi Yamamuro <li...@gmail.com>.
>> Just including a link to a JIRA issue in a github pull request, it's
>> automatically linked.
Aha, I see. I did't know that, great!
ISTM that's enough for us.
// maropu
On Mon, Dec 5, 2016 at 3:52 PM, Makoto Yui <yu...@gmail.com> wrote:
> Takeshi,
>
> I'm not sure but it could be configured by asking ASF infra team.
>
> Just including a link to a JIRA issue in a github pull request, it's
> automatically linked.
>
> See what happened in
> https://github.com/apache/incubator-hivemall/pull/8
> https://issues.apache.org/jira/browse/HIVEMALL-22
>
> Thanks,
> Makoto
>
> 2016-12-05 15:34 GMT+09:00 Takeshi Yamamuro <li...@gmail.com>:
> > Can we set JIRA configurations to automatically put links from issues of
> > JIRA into prs in github?
> > If we can't, should we put their links manually?
> >
> > // maropu
> >
> >
> > On Mon, Dec 5, 2016 at 3:23 PM, Kai Sasaki <sa...@treasure-data.com>
> wrote:
> >
> >> Okay, sounds good.
> >>
> >> Kai
> >>
> >>
> >> > On 2016 Dec 5, at 15:15, Makoto Yui <my...@apache.org> wrote:
> >> >
> >> > I'm considering the following steps for Hivemall contribution
> procedure:
> >> >
> >> > 1). fork ASF mirror https://github.com/apache/incubator-hivemall
> >> > 2). work on local branch (hotfix/xxx, JIRA-xxx)
> >> > better to create a JIRA issue if the pull requests is not a hotfix
> >> > Pull request need to be linked to a JIRA issue
> >> > 3). create pull request to the master branch of
> >> > https://github.com/apache/incubator-hivemall
> >> > 4). review on github pull requests
> >> > 5). merge (-squash) on the master branch and push to ASF git
> >> > repository (by committer's role)
> >> >
> >> > I'll update the contribution guide and make it more simple one.
> >> >
> >> >> Kai,
> >> > So, do not push branches to ASF repository.
> >> > Initial migrated branches are exceptional ones.
> >> >
> >> > Better to keep ASF git repository clean.
> >> >
> >> > Thanks,
> >> > Makoto
> >>
> >>
> >
> >
> > --
> > ---
> > Takeshi Yamamuro
>
--
---
Takeshi Yamamuro
Re: Contribution guideline
Posted by Makoto Yui <yu...@gmail.com>.
Takeshi,
I'm not sure but it could be configured by asking ASF infra team.
Just including a link to a JIRA issue in a github pull request, it's
automatically linked.
See what happened in
https://github.com/apache/incubator-hivemall/pull/8
https://issues.apache.org/jira/browse/HIVEMALL-22
Thanks,
Makoto
2016-12-05 15:34 GMT+09:00 Takeshi Yamamuro <li...@gmail.com>:
> Can we set JIRA configurations to automatically put links from issues of
> JIRA into prs in github?
> If we can't, should we put their links manually?
>
> // maropu
>
>
> On Mon, Dec 5, 2016 at 3:23 PM, Kai Sasaki <sa...@treasure-data.com> wrote:
>
>> Okay, sounds good.
>>
>> Kai
>>
>>
>> > On 2016 Dec 5, at 15:15, Makoto Yui <my...@apache.org> wrote:
>> >
>> > I'm considering the following steps for Hivemall contribution procedure:
>> >
>> > 1). fork ASF mirror https://github.com/apache/incubator-hivemall
>> > 2). work on local branch (hotfix/xxx, JIRA-xxx)
>> > better to create a JIRA issue if the pull requests is not a hotfix
>> > Pull request need to be linked to a JIRA issue
>> > 3). create pull request to the master branch of
>> > https://github.com/apache/incubator-hivemall
>> > 4). review on github pull requests
>> > 5). merge (-squash) on the master branch and push to ASF git
>> > repository (by committer's role)
>> >
>> > I'll update the contribution guide and make it more simple one.
>> >
>> >> Kai,
>> > So, do not push branches to ASF repository.
>> > Initial migrated branches are exceptional ones.
>> >
>> > Better to keep ASF git repository clean.
>> >
>> > Thanks,
>> > Makoto
>>
>>
>
>
> --
> ---
> Takeshi Yamamuro
Re: Contribution guideline
Posted by Takeshi Yamamuro <li...@gmail.com>.
Can we set JIRA configurations to automatically put links from issues of
JIRA into prs in github?
If we can't, should we put their links manually?
// maropu
On Mon, Dec 5, 2016 at 3:23 PM, Kai Sasaki <sa...@treasure-data.com> wrote:
> Okay, sounds good.
>
> Kai
>
>
> > On 2016 Dec 5, at 15:15, Makoto Yui <my...@apache.org> wrote:
> >
> > I'm considering the following steps for Hivemall contribution procedure:
> >
> > 1). fork ASF mirror https://github.com/apache/incubator-hivemall
> > 2). work on local branch (hotfix/xxx, JIRA-xxx)
> > better to create a JIRA issue if the pull requests is not a hotfix
> > Pull request need to be linked to a JIRA issue
> > 3). create pull request to the master branch of
> > https://github.com/apache/incubator-hivemall
> > 4). review on github pull requests
> > 5). merge (-squash) on the master branch and push to ASF git
> > repository (by committer's role)
> >
> > I'll update the contribution guide and make it more simple one.
> >
> >> Kai,
> > So, do not push branches to ASF repository.
> > Initial migrated branches are exceptional ones.
> >
> > Better to keep ASF git repository clean.
> >
> > Thanks,
> > Makoto
>
>
--
---
Takeshi Yamamuro
Re: Contribution guideline
Posted by Kai Sasaki <sa...@treasure-data.com>.
Okay, sounds good.
Kai
> On 2016 Dec 5, at 15:15, Makoto Yui <my...@apache.org> wrote:
>
> I'm considering the following steps for Hivemall contribution procedure:
>
> 1). fork ASF mirror https://github.com/apache/incubator-hivemall
> 2). work on local branch (hotfix/xxx, JIRA-xxx)
> better to create a JIRA issue if the pull requests is not a hotfix
> Pull request need to be linked to a JIRA issue
> 3). create pull request to the master branch of
> https://github.com/apache/incubator-hivemall
> 4). review on github pull requests
> 5). merge (-squash) on the master branch and push to ASF git
> repository (by committer's role)
>
> I'll update the contribution guide and make it more simple one.
>
>> Kai,
> So, do not push branches to ASF repository.
> Initial migrated branches are exceptional ones.
>
> Better to keep ASF git repository clean.
>
> Thanks,
> Makoto