You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/02 19:06:00 UTC

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1179: libc: Implement vscanf() function

patacongo commented on a change in pull request #1179:
URL: https://github.com/apache/incubator-nuttx/pull/1179#discussion_r434112939



##########
File path: libs/libc/stdio/lib_vprintf.c
##########
@@ -49,7 +52,13 @@
 
 int vprintf(FAR const IPTR char *fmt, va_list ap)
 {
+#if CONFIG_NFILE_STREAMS > 0
   /* vfprintf into stdout */
 
   return vfprintf(stdout, fmt, ap);
+#else
+  /* vsyslog into debug channel */
+
+  return nx_vsyslog(LOG_INFO, fmt, &ap);

Review comment:
       It would be much better to use vdprintf()




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org