You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Magyar <am...@hortonworks.com> on 2017/12/06 11:54:27 UTC
Review Request 64373: A bad WebHDFS request is issued when starting
Hive Metastore
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64373/
-----------------------------------------------------------
Review request for Ambari, Eugene Chekanskiy, Robert Levas, Sandor Molnar, and Sid Wagle.
Bugs: AMBARI-22492
https://issues.apache.org/jira/browse/AMBARI-22492
Repository: ambari
Description
-------
The default values of hive_repl_cmrootdir, hive_repl_rootdir are empty string. The empty string can pass through the existing is None check which will cause the webhdfsresource to build an incorrect url.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py 0c45719
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 603bc92
Diff: https://reviews.apache.org/r/64373/diff/1/
Testing
-------
Tested by starting hiveserver2.
existing tests: pending
Thanks,
Attila Magyar
Re: Review Request 64373: A bad WebHDFS request is issued when
starting Hive Metastore
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64373/#review192988
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On Dec. 6, 2017, 8:04 a.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64373/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2017, 8:04 a.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Robert Levas, Sandor Molnar, and Sid Wagle.
>
>
> Bugs: AMBARI-22492
> https://issues.apache.org/jira/browse/AMBARI-22492
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The default values of hive_repl_cmrootdir, hive_repl_rootdir are empty string. The empty string can pass through the existing "is None" check which will cause the webhdfsresource to build an incorrect url.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py 0c45719
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 603bc92
>
>
> Diff: https://reviews.apache.org/r/64373/diff/1/
>
>
> Testing
> -------
>
> Tested by starting hiveserver2.
>
>
> existing tests:
>
> Ran 276 tests in 7.399s
> OK
> ----------------------------------------------------------------------
> Total run:1200
> Tests run: 4932, Failures: 0, Errors: 0, Skipped: 34
> ----------------------------------------------------------------------
> Ran 455 tests in 97.752s
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 64373: A bad WebHDFS request is issued when
starting Hive Metastore
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64373/#review193041
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Dec. 6, 2017, 1:04 p.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64373/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2017, 1:04 p.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Robert Levas, Sandor Molnar, and Sid Wagle.
>
>
> Bugs: AMBARI-22492
> https://issues.apache.org/jira/browse/AMBARI-22492
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The default values of hive_repl_cmrootdir, hive_repl_rootdir are empty string. The empty string can pass through the existing "is None" check which will cause the webhdfsresource to build an incorrect url.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py 0c45719
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 603bc92
>
>
> Diff: https://reviews.apache.org/r/64373/diff/1/
>
>
> Testing
> -------
>
> Tested by starting hiveserver2.
>
>
> existing tests:
>
> Ran 276 tests in 7.399s
> OK
> ----------------------------------------------------------------------
> Total run:1200
> Tests run: 4932, Failures: 0, Errors: 0, Skipped: 34
> ----------------------------------------------------------------------
> Ran 455 tests in 97.752s
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 64373: A bad WebHDFS request is issued when
starting Hive Metastore
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64373/
-----------------------------------------------------------
(Updated Dec. 6, 2017, 1:04 p.m.)
Review request for Ambari, Eugene Chekanskiy, Robert Levas, Sandor Molnar, and Sid Wagle.
Changes
-------
added test results
Bugs: AMBARI-22492
https://issues.apache.org/jira/browse/AMBARI-22492
Repository: ambari
Description
-------
The default values of hive_repl_cmrootdir, hive_repl_rootdir are empty string. The empty string can pass through the existing "is None" check which will cause the webhdfsresource to build an incorrect url.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py 0c45719
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 603bc92
Diff: https://reviews.apache.org/r/64373/diff/1/
Testing (updated)
-------
Tested by starting hiveserver2.
existing tests:
Ran 276 tests in 7.399s
OK
----------------------------------------------------------------------
Total run:1200
Tests run: 4932, Failures: 0, Errors: 0, Skipped: 34
----------------------------------------------------------------------
Ran 455 tests in 97.752s
Thanks,
Attila Magyar