[GitHub] marcoabreu commented on issue #10921: Test cases improvement for MKLDNN on Gluon

[GitBox <gi...@apache.org>]

marcoabreu commented on issue #10921: Test cases improvement for MKLDNN on Gluon
URL: https://github.com/apache/incubator-mxnet/pull/10921#issuecomment-388618909
 
 
   Hi, thanks for adding these tests! Could you elaborate why we need backend specific tests in a front-end language? Please excuse me if I'm making a misassumption here, but the implementation should be transparent and always act the same.
   
   This means we should not need any MKL specific tests for operators, considering their behaviour should be identical. From my point of view, there should rather be general tests for all operators (in the same style you just wrote them), and they should just succeed if we switch the backend to MKL. 
   
   I'm afraid that we will run into inconsistencies if we start writing custom tests for each backend. Ideally, all backends should produce the exact same output and execute the same behaviour. This would then be verified with general operator tests and thus make custom backend tests obsolete
   
   @szha @piiswrong @zheng-da am I right with my assumption?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services