[GitHub] [hadoop] sidseth commented on a change in pull request #1516: HADOOP-16599. Allow a SignerInitializer to be specified along with a

[GitBox <gi...@apache.org>]

sidseth commented on a change in pull request #1516: HADOOP-16599. Allow a SignerInitializer to be specified along with a
URL: https://github.com/apache/hadoop/pull/1516#discussion_r330093108
 
 

 ##########
 File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DelegationTokenProvider.java
 ##########
 @@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.s3a;
 
 Review comment:
   aws-plugins would help break some circular dependencies.
   Users would ofcourse need to make sure the versions of aws-plugins and aws are the same. In fact, users would only import 'aws' which would automatically include the 'aws-plugins' - in that sense this would not be an incompatible change.
   The intent of switching 'aws-plugins' to a separate module is to allow people writing plugins to not depend on everything, and potentially help with circular dependencies.
   
   IAC, that's unrelated to this jira an PR. Can be taken up later if it makes sense.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org