You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/07/05 07:27:14 UTC
[GitHub] [netbeans] sdedic commented on a change in pull request #1069: NETBEANS-1744: Support Run/Debug Focused Test Method for @Nested JUni…
sdedic commented on a change in pull request #1069:
URL: https://github.com/apache/netbeans/pull/1069#discussion_r663699027
##########
File path: java/maven.junit.ui/src/org/netbeans/modules/maven/junit/ui/MavenJUnitNodeOpener.java
##########
@@ -144,6 +159,24 @@ public void run(CompilationController compilationController) throws Exception {
UIJavaUtils.openFile(fo2open[0], (int) line[0]);
}
}
+
+ private Element findInnermostTypeElement(Element containingTypeElement, List<? extends String> targetInnerClassNames) {
Review comment:
No need to stub `CompilationController:` refactor code to have the tested part callable and save make accessors so the test can collect the computed data. I.e. make the UserTask a package-private member class, so the test can instantiate it. Create sources in test data, then process it using JavaSource.parse(). Call the tested code with (real) CompilationController instance and observe the outcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists