You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "olivier dupuy (JIRA)" <ji...@apache.org> on 2008/03/06 21:51:07 UTC

[jira] Commented: (WW-2065) Field-validator params and ognl

    [ https://issues.apache.org/struts/browse/WW-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43468#action_43468 ] 

olivier dupuy commented on WW-2065:
-----------------------------------

Hello,

I totally agree on the request.
It totally make sense to be able to use constants defined in the application or any other Java code instead.
This make the application much more flexible, easier to maintain (change the constant in one place and done) and much easier to test too as you can use the constants in your test.
The support for OGNL should be present in all the parameters of validation annotations and in XML validators

Vote for it.

> Field-validator params and ognl
> -------------------------------
>
>                 Key: WW-2065
>                 URL: https://issues.apache.org/struts/browse/WW-2065
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: Expression Language
>    Affects Versions: 2.0.9
>            Reporter: Florent Ramière
>            Priority: Minor
>             Fix For: Future
>
>
> XWork bug reproduced here, please remove if appropriate
> ---
> Param values cannot contain ognl values, here is my current validator configuration.
> The ognl possibility in th message is very usefull, it is a pity we cannot do the same on the param side ...
>     <field name="language.name">
>         <field-validator type="requiredstring" short-circuit="true">
>             <message>${getText("validator.requiredstring"}</message>
>         </field-validator>
>         <field-validator type="stringlength">
>             <param name="maxLength">255</param>
>             <message>${getText("validator.stringlength"}</message>
>         </field-validator>
>     </field>
> here is what I wish I could do
>     <field name="language.name">
>         <field-validator type="requiredstring" short-circuit="true">
>             <message>${getText("validator.requiredstring"}</message>
>         </field-validator>
>         <field-validator type="stringlength">
> <!-- here is the requested change--> <param name="maxLength">${getText("maximum.length.language.locale")}</param>
>             <message>${getText("validator.stringlength"}</message>
>         </field-validator>
>     </field> 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.