You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/06/16 02:27:05 UTC
Review Request 35483: Removing deprecated JobUpdateSummary fields.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35483/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Zameer Manji.
Bugs: AURORA-1139
https://issues.apache.org/jira/browse/AURORA-1139
Repository: aurora
Description
-------
Finalizing `JobUpdateKey` migration.
Diffs
-----
api/src/main/thrift/org/apache/aurora/gen/api.thrift dd54e5b50050540b8599003786c79e4b033f3739
api/src/main/thrift/org/apache/aurora/gen/storage.thrift 26c5db8a6564f6baa40da685c52d60b40e20f633
src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java 3c6d4c992a6edcf9d4e438e75d8448021c886b17
src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 1a63169c26ff57467010cfea42d6ce33eb427c5b
src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 159cb0cfb03255d1dff87549f07c4d049af78a23
src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 4b9d7f5d292e42be4ab720aa61f457c69c58f5b2
src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java b1b6f11ca25cf1c6c4566af35a6334514251922c
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java c58f531fdd9e860e67037605ec5804870ed0a79f
src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java c5e2323ef222cecc4ff30790e2f28f2c70dd1b54
src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java e61a6b4ec914540cfbcec79235f7b9af9443faaf
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 1ca3a9bb58207d7a9167b2762e0fed24219722b5
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 1ebfa64edf578d0008b48b12438a5eae9237b809
src/main/java/org/apache/aurora/scheduler/updater/Updates.java 646647382b89d315bc1b31795228c0461940bac1
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml cf31cf8be43161b8146aa79cfc62e6cc17a71db3
src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 1ff8d23e31e1c61e242079fba5056119f8d869b4
src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java d1d7e799219627c0ed94061401e7c7f4c13c12a5
src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java cbc2d38a9d73c725c3be7fb161c07b307ea3b2f2
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 982968af52fdaa9c39f51bdac6b082ae839b6c7a
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 52c72620a3833331ee086d81a3751dfe397a3a6f
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21b40448e0da814831fc6b2ed62ddb326efda910
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 7aa19d43d243899682bca54210637a8286ca0b9c
Diff: https://reviews.apache.org/r/35483/diff/
Testing
-------
./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
Re: Review Request 35483: Removing deprecated JobUpdateSummary fields.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35483/#review88012
-----------------------------------------------------------
Ship it!
Master (185b48e) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 16, 2015, 12:27 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35483/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 12:27 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
>
>
> Bugs: AURORA-1139
> https://issues.apache.org/jira/browse/AURORA-1139
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Finalizing `JobUpdateKey` migration.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift dd54e5b50050540b8599003786c79e4b033f3739
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift 26c5db8a6564f6baa40da685c52d60b40e20f633
> src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java 3c6d4c992a6edcf9d4e438e75d8448021c886b17
> src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 1a63169c26ff57467010cfea42d6ce33eb427c5b
> src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 159cb0cfb03255d1dff87549f07c4d049af78a23
> src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 4b9d7f5d292e42be4ab720aa61f457c69c58f5b2
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java b1b6f11ca25cf1c6c4566af35a6334514251922c
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java c58f531fdd9e860e67037605ec5804870ed0a79f
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java c5e2323ef222cecc4ff30790e2f28f2c70dd1b54
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java e61a6b4ec914540cfbcec79235f7b9af9443faaf
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 1ca3a9bb58207d7a9167b2762e0fed24219722b5
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 1ebfa64edf578d0008b48b12438a5eae9237b809
> src/main/java/org/apache/aurora/scheduler/updater/Updates.java 646647382b89d315bc1b31795228c0461940bac1
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml cf31cf8be43161b8146aa79cfc62e6cc17a71db3
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 1ff8d23e31e1c61e242079fba5056119f8d869b4
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java d1d7e799219627c0ed94061401e7c7f4c13c12a5
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java cbc2d38a9d73c725c3be7fb161c07b307ea3b2f2
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 982968af52fdaa9c39f51bdac6b082ae839b6c7a
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 52c72620a3833331ee086d81a3751dfe397a3a6f
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21b40448e0da814831fc6b2ed62ddb326efda910
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 7aa19d43d243899682bca54210637a8286ca0b9c
>
> Diff: https://reviews.apache.org/r/35483/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 35483: Removing deprecated JobUpdateSummary fields.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35483/#review88011
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On June 15, 2015, 5:27 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35483/
> -----------------------------------------------------------
>
> (Updated June 15, 2015, 5:27 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
>
>
> Bugs: AURORA-1139
> https://issues.apache.org/jira/browse/AURORA-1139
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Finalizing `JobUpdateKey` migration.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift dd54e5b50050540b8599003786c79e4b033f3739
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift 26c5db8a6564f6baa40da685c52d60b40e20f633
> src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java 3c6d4c992a6edcf9d4e438e75d8448021c886b17
> src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 1a63169c26ff57467010cfea42d6ce33eb427c5b
> src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 159cb0cfb03255d1dff87549f07c4d049af78a23
> src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 4b9d7f5d292e42be4ab720aa61f457c69c58f5b2
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java b1b6f11ca25cf1c6c4566af35a6334514251922c
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java c58f531fdd9e860e67037605ec5804870ed0a79f
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java c5e2323ef222cecc4ff30790e2f28f2c70dd1b54
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java e61a6b4ec914540cfbcec79235f7b9af9443faaf
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 1ca3a9bb58207d7a9167b2762e0fed24219722b5
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 1ebfa64edf578d0008b48b12438a5eae9237b809
> src/main/java/org/apache/aurora/scheduler/updater/Updates.java 646647382b89d315bc1b31795228c0461940bac1
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml cf31cf8be43161b8146aa79cfc62e6cc17a71db3
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 1ff8d23e31e1c61e242079fba5056119f8d869b4
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java d1d7e799219627c0ed94061401e7c7f4c13c12a5
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java cbc2d38a9d73c725c3be7fb161c07b307ea3b2f2
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 982968af52fdaa9c39f51bdac6b082ae839b6c7a
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 52c72620a3833331ee086d81a3751dfe397a3a6f
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21b40448e0da814831fc6b2ed62ddb326efda910
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 7aa19d43d243899682bca54210637a8286ca0b9c
>
> Diff: https://reviews.apache.org/r/35483/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 35483: Removing deprecated JobUpdateSummary fields.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35483/#review88010
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On June 15, 2015, 5:27 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35483/
> -----------------------------------------------------------
>
> (Updated June 15, 2015, 5:27 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
>
>
> Bugs: AURORA-1139
> https://issues.apache.org/jira/browse/AURORA-1139
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Finalizing `JobUpdateKey` migration.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift dd54e5b50050540b8599003786c79e4b033f3739
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift 26c5db8a6564f6baa40da685c52d60b40e20f633
> src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java 3c6d4c992a6edcf9d4e438e75d8448021c886b17
> src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 1a63169c26ff57467010cfea42d6ce33eb427c5b
> src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 159cb0cfb03255d1dff87549f07c4d049af78a23
> src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 4b9d7f5d292e42be4ab720aa61f457c69c58f5b2
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java b1b6f11ca25cf1c6c4566af35a6334514251922c
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java c58f531fdd9e860e67037605ec5804870ed0a79f
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java c5e2323ef222cecc4ff30790e2f28f2c70dd1b54
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java e61a6b4ec914540cfbcec79235f7b9af9443faaf
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 1ca3a9bb58207d7a9167b2762e0fed24219722b5
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 1ebfa64edf578d0008b48b12438a5eae9237b809
> src/main/java/org/apache/aurora/scheduler/updater/Updates.java 646647382b89d315bc1b31795228c0461940bac1
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml cf31cf8be43161b8146aa79cfc62e6cc17a71db3
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 1ff8d23e31e1c61e242079fba5056119f8d869b4
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java d1d7e799219627c0ed94061401e7c7f4c13c12a5
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java cbc2d38a9d73c725c3be7fb161c07b307ea3b2f2
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 982968af52fdaa9c39f51bdac6b082ae839b6c7a
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 52c72620a3833331ee086d81a3751dfe397a3a6f
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21b40448e0da814831fc6b2ed62ddb326efda910
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 7aa19d43d243899682bca54210637a8286ca0b9c
>
> Diff: https://reviews.apache.org/r/35483/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>