You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/09/02 15:56:33 UTC
[GitHub] [accumulo] milleruntime opened a new pull request #2260: Reword some comments to clarify
milleruntime opened a new pull request #2260:
URL: https://github.com/apache/accumulo/pull/2260
* Also rename some methods in CompactableImpl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on pull request #2260: Reword some comments to clarify
Posted by GitBox <gi...@apache.org>.
keith-turner commented on pull request #2260:
URL: https://github.com/apache/accumulo/pull/2260#issuecomment-911867521
> @keith-turner One comment I was hoping we could expand on was "So the selected set must be initialized." I am not sure if that means in the current method or before calling the current method.
Seems like it initializes some instance var in the method and also uses the returned value to initialize some more instance var later in the constructor. I don't think anything is initialized before the method call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2260: Reword some comments to clarify
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2260:
URL: https://github.com/apache/accumulo/pull/2260#issuecomment-911857889
@keith-turner One comment I was hoping we could expand on was "So the selected set must be initialized." I am not sure if that means in the current method or before calling the current method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2260: Reword some comments to clarify
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2260:
URL: https://github.com/apache/accumulo/pull/2260#issuecomment-911875985
> > @keith-turner One comment I was hoping we could expand on was "So the selected set must be initialized." I am not sure if that means in the current method or before calling the current method.
>
> Seems like it initializes some instance var in the method and also uses the returned value to initialize some more instance var later in the constructor. I don't think anything is initialized before the method call.
OK I think I am going to just drop that sentence since it doesn't really add anything and is just confusing me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime merged pull request #2260: Reword some comments to clarify
Posted by GitBox <gi...@apache.org>.
milleruntime merged pull request #2260:
URL: https://github.com/apache/accumulo/pull/2260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org