You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by "Paulex Yang (JIRA)" <ji...@apache.org> on 2006/02/27 09:44:56 UTC
[jira] Commented: (HARMONY-137) CharsetDecoder should replace
undefined bytes with replacement string
[ http://issues.apache.org/jira/browse/HARMONY-137?page=comments#action_12367917 ]
Paulex Yang commented on HARMONY-137:
-------------------------------------
A little investigation on the Harmony codes, seems it is caused by problems of ICU4JNI decoder provider, the following test cases shows that. RI "cp1250" passes the testcase while ICU "cp1250" fails under either RI or Harmony . I'll try to report the bug to ICU.
Test case:
public void testDecode_JIRA137() {
ByteBuffer bb = ByteBuffer.allocate(5);
bb.put((byte) 0x81);
bb.flip();
// Use ICU cp1250 charset
CharsetProviderICU provider = new CharsetProviderICU();
Charset cp1250 = provider.charsetForName("cp1250");
// Uncomment code below to use RI charset
//cp1250 = Charset.forName("cp1250");
CharBuffer cb;
try {
cb = cp1250.newDecoder()
.onMalformedInput(CodingErrorAction.REPLACE)
.onUnmappableCharacter(CodingErrorAction.REPLACE)
.decode(bb);
assertEquals(0XFFFD,cb.get(0));
} catch (CharacterCodingException e) {
e.printStackTrace();
}
}
> CharsetDecoder should replace undefined bytes with replacement string
> ---------------------------------------------------------------------
>
> Key: HARMONY-137
> URL: http://issues.apache.org/jira/browse/HARMONY-137
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Vladimir Strigun
> Priority: Minor
>
> Corresponding to cp1250 mapping table, 0x81 byte is undefined. See http://www.unicode.org/Public/MAPPINGS/VENDORS/MICSFT/WINDOWS/CP1250.TXT
> So, charset decoder should replace undefined bytes with default replacement, i.e. 0xFFFD.
> Testcase for reproducing this issue:
> import java.nio.charset.*;
> import java.nio.*;
> public class Harmony137 {
> public static void main(String[] args) throws Exception {
> ByteBuffer bb = ByteBuffer.allocate(5);
> bb.put((byte)0x81); bb.flip();
> Charset cp1250 = Charset.forName("cp1250");
> CharBuffer cb = cp1250.newDecoder().onMalformedInput(CodingErrorAction.REPLACE).onUnmappableCharacter(CodingErrorAction.REPLACE).decode(bb);
> if(cb.get(0)!=65533) {
> System.out.println("FAIL: expected 0xFFFD but result is: 0x"+Integer.toHexString(cb.get(0)).toUpperCase());
> }
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (HARMONY-137) CharsetDecoder should replace
undefined bytes with replacement string
Posted by Tim Ellison <t....@gmail.com>.
Paulex,
Please add the ICU bug number to this JIRA when you have it -- thanks.
Regards,
Tim
Paulex Yang (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/HARMONY-137?page=comments#action_12367917 ]
>
> Paulex Yang commented on HARMONY-137:
> -------------------------------------
>
> A little investigation on the Harmony codes, seems it is caused by problems of ICU4JNI decoder provider, the following test cases shows that. RI "cp1250" passes the testcase while ICU "cp1250" fails under either RI or Harmony . I'll try to report the bug to ICU.
>
> Test case:
>
> public void testDecode_JIRA137() {
> ByteBuffer bb = ByteBuffer.allocate(5);
> bb.put((byte) 0x81);
> bb.flip();
> // Use ICU cp1250 charset
> CharsetProviderICU provider = new CharsetProviderICU();
> Charset cp1250 = provider.charsetForName("cp1250");
> // Uncomment code below to use RI charset
> //cp1250 = Charset.forName("cp1250");
> CharBuffer cb;
> try {
> cb = cp1250.newDecoder()
> .onMalformedInput(CodingErrorAction.REPLACE)
> .onUnmappableCharacter(CodingErrorAction.REPLACE)
> .decode(bb);
> assertEquals(0XFFFD,cb.get(0));
> } catch (CharacterCodingException e) {
> e.printStackTrace();
> }
> }
>
>> CharsetDecoder should replace undefined bytes with replacement string
>> ---------------------------------------------------------------------
>>
>> Key: HARMONY-137
>> URL: http://issues.apache.org/jira/browse/HARMONY-137
>> Project: Harmony
>> Type: Bug
>> Components: Classlib
>> Reporter: Vladimir Strigun
>> Priority: Minor
>
>> Corresponding to cp1250 mapping table, 0x81 byte is undefined. See http://www.unicode.org/Public/MAPPINGS/VENDORS/MICSFT/WINDOWS/CP1250.TXT
>> So, charset decoder should replace undefined bytes with default replacement, i.e. 0xFFFD.
>> Testcase for reproducing this issue:
>> import java.nio.charset.*;
>> import java.nio.*;
>> public class Harmony137 {
>> public static void main(String[] args) throws Exception {
>> ByteBuffer bb = ByteBuffer.allocate(5);
>> bb.put((byte)0x81); bb.flip();
>> Charset cp1250 = Charset.forName("cp1250");
>> CharBuffer cb = cp1250.newDecoder().onMalformedInput(CodingErrorAction.REPLACE).onUnmappableCharacter(CodingErrorAction.REPLACE).decode(bb);
>> if(cb.get(0)!=65533) {
>> System.out.println("FAIL: expected 0xFFFD but result is: 0x"+Integer.toHexString(cb.get(0)).toUpperCase());
>> }
>> }
>> }
>
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.