You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by bhavik patel <bh...@gmail.com> on 2022/03/23 04:46:07 UTC
Review Request 73910: RANGER-3672 : Show better error messages during failed logins
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73910/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Dhaval Rajpara, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3672
https://issues.apache.org/jira/browse/RANGER-3672
Repository: ranger
Description
-------
When login failure, There are no conspicuous error tips and reasons, just a small red triangle. Should give user a big error prompt box, tell him "The username or password you entered is incorrect..", "The user is disabled or locked for too many attempts. Try again 5 minutes later".
Diffs
-----
security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java efd541757
security-admin/src/main/java/org/apache/ranger/security/listener/SpringEventListener.java 9b048a0dd
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 680fe58ae
Diff: https://reviews.apache.org/r/73910/diff/1/
Testing
-------
Verified on local vm's and screen-shot attached on Jira.
Thanks,
bhavik patel
Re: Review Request 73910: RANGER-3672 : Show better error messages during failed logins
Posted by Kirby Zhou <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73910/#review224203
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java
Line 152 (original), 152 (patched)
<https://reviews.apache.org/r/73910/#comment313099>
try this?
protected MessageSourceAccessor messages = SpringSecurityMessageSource.getAccessor();
...
throw new LockedException(AbstractUserDetailsAuthenticationProvider.this.messages
.getMessage("AbstractUserDetailsAuthenticationProvider.locked", "User account is locked"));
- Kirby Zhou
On 三月 23, 2022, 10:13 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73910/
> -----------------------------------------------------------
>
> (Updated 三月 23, 2022, 10:13 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Dhaval Rajpara, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3672
> https://issues.apache.org/jira/browse/RANGER-3672
>
>
> Repository: ranger
>
>
> Description
> -------
>
> When login failure, There are no conspicuous error tips and reasons, just a small red triangle. Should give user a big error prompt box, tell him "The username or password you entered is incorrect..", "The user is disabled or locked for too many attempts. Try again 5 minutes later".
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java efd541757
> security-admin/src/main/java/org/apache/ranger/security/listener/SpringEventListener.java 9b048a0dd
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 680fe58ae
>
>
> Diff: https://reviews.apache.org/r/73910/diff/2/
>
>
> Testing
> -------
>
> Verified on local vm's and screen-shot attached on Jira.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 73910: RANGER-3672 : Show better error messages during failed logins
Posted by Kirby Zhou <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73910/#review224206
-----------------------------------------------------------
Ship it!
Ship It!
- Kirby Zhou
On 三月 24, 2022, 4:13 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73910/
> -----------------------------------------------------------
>
> (Updated 三月 24, 2022, 4:13 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Dhaval Rajpara, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3672
> https://issues.apache.org/jira/browse/RANGER-3672
>
>
> Repository: ranger
>
>
> Description
> -------
>
> When login failure, There are no conspicuous error tips and reasons, just a small red triangle. Should give user a big error prompt box, tell him "The username or password you entered is incorrect..", "The user is disabled or locked for too many attempts. Try again 5 minutes later".
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java efd541757
> security-admin/src/main/java/org/apache/ranger/security/listener/SpringEventListener.java 9b048a0dd
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 680fe58ae
>
>
> Diff: https://reviews.apache.org/r/73910/diff/3/
>
>
> Testing
> -------
>
> Verified on local vm's and screen-shot attached on Jira.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 73910: RANGER-3672 : Show better error messages during failed logins
Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73910/
-----------------------------------------------------------
(Updated March 24, 2022, 4:13 a.m.)
Review request for ranger, Ankita Sinha, Dhaval Rajpara, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3672
https://issues.apache.org/jira/browse/RANGER-3672
Repository: ranger
Description
-------
When login failure, There are no conspicuous error tips and reasons, just a small red triangle. Should give user a big error prompt box, tell him "The username or password you entered is incorrect..", "The user is disabled or locked for too many attempts. Try again 5 minutes later".
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java efd541757
security-admin/src/main/java/org/apache/ranger/security/listener/SpringEventListener.java 9b048a0dd
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 680fe58ae
Diff: https://reviews.apache.org/r/73910/diff/3/
Changes: https://reviews.apache.org/r/73910/diff/2-3/
Testing
-------
Verified on local vm's and screen-shot attached on Jira.
Thanks,
bhavik patel
Re: Review Request 73910: RANGER-3672 : Show better error messages during failed logins
Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73910/
-----------------------------------------------------------
(Updated March 23, 2022, 10:13 a.m.)
Review request for ranger, Ankita Sinha, Dhaval Rajpara, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3672
https://issues.apache.org/jira/browse/RANGER-3672
Repository: ranger
Description
-------
When login failure, There are no conspicuous error tips and reasons, just a small red triangle. Should give user a big error prompt box, tell him "The username or password you entered is incorrect..", "The user is disabled or locked for too many attempts. Try again 5 minutes later".
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java efd541757
security-admin/src/main/java/org/apache/ranger/security/listener/SpringEventListener.java 9b048a0dd
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 680fe58ae
Diff: https://reviews.apache.org/r/73910/diff/2/
Changes: https://reviews.apache.org/r/73910/diff/1-2/
Testing
-------
Verified on local vm's and screen-shot attached on Jira.
Thanks,
bhavik patel