[jira] [Commented] (AIRFLOW-2933) Enable Codecov on Docker CI

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588552#comment-16588552 ] 

ASF GitHub Bot commented on AIRFLOW-2933:
-----------------------------------------

Fokko opened a new pull request #3780: [AIRFLOW-2933] Enable Codecov on Docker-CI Build
URL: https://github.com/apache/incubator-airflow/pull/3780
 
 
   Add missing variables and use codecov instead of coveralls. The issue why it wasn't working was because missing environment variables. The codecov library heavily depends on the environment variables in the CI to determine how to push the reports to codecov.
   
   I've removed the explicit passing of the variables in the `tox.ini` since we also do it at the `docker-compose.yml`, having to maintain this at two places makes it brittle.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-2933\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-2933\], code changes always need a Jira issue.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Enable Codecov on Docker CI
> ---------------------------
>
>                 Key: AIRFLOW-2933
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2933
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Fokko Driesprong
>            Priority: Major
>
> Right now the Codecov plugin is not working on the docker-ci that we're using right now. This has to be fixed so we can track code coverage over time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)