[GitHub] [hadoop] abhishekdas99 commented on a change in pull request #3639: HADOOP-17999: Do not initialize all target FileSystems for setWriteChecksum and setVerifyChecksum

[GitBox <gi...@apache.org>]

abhishekdas99 commented on a change in pull request #3639:
URL: https://github.com/apache/hadoop/pull/3639#discussion_r750770445



##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
##########
@@ -917,13 +917,9 @@ public void removeXAttr(Path path, String name) throws IOException {
   }
 
   @Override
-  public void setVerifyChecksum(final boolean verifyChecksum) { 
-    List<InodeTree.MountPoint<FileSystem>> mountPoints = 
-        fsState.getMountPoints();
-    Map<String, FileSystem> fsMap = initializeMountedFileSystems(mountPoints);
-    for (InodeTree.MountPoint<FileSystem> mount : mountPoints) {
-      fsMap.get(mount.src).setVerifyChecksum(verifyChecksum);
-    }
+  public void setVerifyChecksum(final boolean verifyChecksum) {

Review comment:
       We still want to keep overriding the two methods in ViewFileSystem (same as ViewFs) so that we explicitly say these are no-ops and doesn't depend on the FileSystem implementation (if anything changes in future)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org