You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ij...@apache.org on 2017/10/22 23:54:48 UTC
kafka git commit: MINOR: Changed visibility of methods in
ClusterConnectionStates to private
Repository: kafka
Updated Branches:
refs/heads/trunk b1cd6c530 -> 86cd558b3
MINOR: Changed visibility of methods in ClusterConnectionStates to private
The methods resetReconnectBackoff and updateReconnectBackoff in ClusterConnectionStates both take an instance of a private inner class as parameter and thus cannot be called from outside the class anyway.
Author: Soenke Liebau <so...@opencore.com>
Reviewers: Ismael Juma <is...@juma.me.uk>
Closes #4114 from soenkeliebau/MINOR_private
Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/86cd558b
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/86cd558b
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/86cd558b
Branch: refs/heads/trunk
Commit: 86cd558b3345879429ba177de8ff5b40e1219e73
Parents: b1cd6c5
Author: Soenke Liebau <so...@opencore.com>
Authored: Mon Oct 23 00:54:44 2017 +0100
Committer: Ismael Juma <is...@juma.me.uk>
Committed: Mon Oct 23 00:54:44 2017 +0100
----------------------------------------------------------------------
.../java/org/apache/kafka/clients/ClusterConnectionStates.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kafka/blob/86cd558b/clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java b/clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java
index 5bc25de..0055843 100644
--- a/clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java
+++ b/clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java
@@ -199,7 +199,7 @@ final class ClusterConnectionStates {
*
* @param nodeState The node state object to update
*/
- public void resetReconnectBackoff(NodeConnectionState nodeState) {
+ private void resetReconnectBackoff(NodeConnectionState nodeState) {
nodeState.failedAttempts = 0;
nodeState.reconnectBackoffMs = this.reconnectBackoffInitMs;
}
@@ -211,7 +211,7 @@ final class ClusterConnectionStates {
*
* @param nodeState The node state object to update
*/
- public void updateReconnectBackoff(NodeConnectionState nodeState) {
+ private void updateReconnectBackoff(NodeConnectionState nodeState) {
if (this.reconnectBackoffMaxMs > this.reconnectBackoffInitMs) {
nodeState.failedAttempts += 1;
double backoffExp = Math.min(nodeState.failedAttempts - 1, this.reconnectBackoffMaxExp);