You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gliptak <gi...@git.apache.org> on 2016/03/20 15:01:59 UTC
[GitHub] spark pull request: SPARK-13461 Delete duplicate example TrainVali...
GitHub user gliptak opened a pull request:
https://github.com/apache/spark/pull/11853
SPARK-13461 Delete duplicate example TrainValidationSplitExample.scala
https://issues.apache.org/jira/browse/SPARK-13461
Validated that examples/src/main/scala/org/apache/spark/examples/ml/TrainValidationSplitExample.scala is not referenced.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gliptak/spark SPARK-13461
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11853.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11853
----
commit dea01f278226791e72ee094170f70d3c229041fb
Author: Gábor Lipták <gl...@gmail.com>
Date: 2016-03-20T13:58:36Z
SPARK-13461 Delete duplicate example TrainValidationSplitExample.scala
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-13461 Delete duplicate example TrainVali...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11853#issuecomment-198939012
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53637/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-13461 Delete duplicate example TrainVali...
Posted by yinxusen <gi...@git.apache.org>.
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/11853#issuecomment-204014653
@gliptak @mengxr Here is an example of scala/examples/ml: https://github.com/apache/spark/pull/12092. You can find all JIRAs here: https://issues.apache.org/jira/browse/SPARK-13461
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-13461 Delete duplicate example TrainVali...
Posted by gliptak <gi...@git.apache.org>.
Github user gliptak closed the pull request at:
https://github.com/apache/spark/pull/11853
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-13461 Delete duplicate example TrainVali...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11853#issuecomment-198938935
**[Test build #53637 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53637/consoleFull)** for PR 11853 at commit [`dea01f2`](https://github.com/apache/spark/commit/dea01f278226791e72ee094170f70d3c229041fb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-13461 Delete duplicate example TrainVali...
Posted by gliptak <gi...@git.apache.org>.
Github user gliptak commented on the pull request:
https://github.com/apache/spark/pull/11853#issuecomment-198951746
@srowen I asked for clarification on the other item listed ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-13461 Delete duplicate example TrainVali...
Posted by yinxusen <gi...@git.apache.org>.
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/11853#issuecomment-200473813
@gliptak @mengxr How about we deleting those files listed here https://issues.apache.org/jira/browse/SPARK-14041 directly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-13461 Delete duplicate example TrainVali...
Posted by yinxusen <gi...@git.apache.org>.
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/11853#issuecomment-199060871
@gliptak This JIRA is to find all duplicated example codes for mllib and ml packages, in Scala/Python/Java. So you need to do some research works and find out those duplicates. And also, be careful with those unmerged JIRAs under [SPARK-11337](https://issues.apache.org/jira/browse/SPARK-11337). They may introduce new duplicates.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-13461 Delete duplicate example TrainVali...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11853#issuecomment-199416076
@yinxusen It doesn't seems feasible to me to find all duplicated examples in all languages in a single PR. Shall we list possible merges first and then group the tasks into a few JIRAs?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-13461 Delete duplicate example TrainVali...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11853#issuecomment-198939008
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-13461 Delete duplicate example TrainVali...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11853#issuecomment-198940929
This isn't all the items from the JIRA right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-13461 Delete duplicate example TrainVali...
Posted by yinxusen <gi...@git.apache.org>.
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/11853#issuecomment-199434416
@mengxr Of course. I'll list them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-13461 Delete duplicate example TrainVali...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11853#issuecomment-198933288
**[Test build #53637 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53637/consoleFull)** for PR 11853 at commit [`dea01f2`](https://github.com/apache/spark/commit/dea01f278226791e72ee094170f70d3c229041fb).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org