You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/27 09:54:21 UTC

[GitHub] [flink] XComp commented on a change in pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config

XComp commented on a change in pull request #13747:
URL: https://github.com/apache/flink/pull/13747#discussion_r512551392



##########
File path: flink-dist/src/main/flink-bin/bin/jobmanager.sh
##########
@@ -51,6 +51,10 @@ if [[ $STARTSTOP == "start" ]] || [[ $STARTSTOP == "start-foreground" ]]; then
         args+=("--webui-port")
         args+=("${WEBUIPORT}")
     fi
+
+    if [ ! -z "${DYNAMIC_PARAMETERS+x}" ]; then

Review comment:
       True I forgot to align all of that. The variable extension is not necessary in our case. Hence, I removed it again aligning all three code snippets.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org