You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Lars Hofhansl (Created) (JIRA)" <ji...@apache.org> on 2011/10/19 23:25:10 UTC
[jira] [Created] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Filters unnecessarily copy byte arrays...
-----------------------------------------
Key: HBASE-4626
URL: https://issues.apache.org/jira/browse/HBASE-4626
Project: HBase
Issue Type: Bug
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131047#comment-13131047 ]
Ted Yu commented on HBASE-4626:
-------------------------------
Interesting finding.
WritableByteArrayComparable should be enhanced with:
{code}
public int compareTo(byte[] buffer, int offset, int length)
{code}
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131207#comment-13131207 ]
Ted Yu commented on HBASE-4626:
-------------------------------
Nice work.
Please fill in javadoc for return value:
{code}
+ * @return
+ */
+ public abstract int compareTo(byte [] value, int offset, int length);
{code}
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4626.txt
>
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132299#comment-13132299 ]
Lars Hofhansl commented on HBASE-4626:
--------------------------------------
Committed to trunk.
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4626-v2.txt, 4626-v3.txt, 4626.txt
>
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131358#comment-13131358 ]
Lars Hofhansl commented on HBASE-4626:
--------------------------------------
All tests pass BTW. (TestHFileBlock fails with or without my change).
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4626-v2.txt, 4626.txt
>
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-4626:
---------------------------------
Fix Version/s: 0.92.0
Agreed.
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4626-v2.txt, 4626.txt
>
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131355#comment-13131355 ]
Ted Yu commented on HBASE-4626:
-------------------------------
Since this is a bug, I think it should go to 0.92 as well.
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4626-v2.txt, 4626.txt
>
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-4626:
---------------------------------
Attachment: 4626.txt
Patch against trunk.
Tests still running...
On scans touching many rows with a filter, this should significantly cut down garbage.
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Attachments: 4626.txt
>
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131360#comment-13131360 ]
Lars Hofhansl commented on HBASE-4626:
--------------------------------------
Well, actually... It is a performance improvement, not a bug per se.
Would make a nice addition to our 0.94 performance release (shortly after 0.92, right? :) )
Seriously, if this is considered a bug I'll commit it to 0.92 too, it's pretty low risk.
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4626-v2.txt, 4626.txt
>
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-4626:
---------------------------------
Component/s: regionserver
Fix Version/s: 0.94.0
Targeting 0.94. But this is simple and could be put into 0.92 as well.
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4626.txt
>
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131354#comment-13131354 ]
Lars Hofhansl commented on HBASE-4626:
--------------------------------------
I will commit this to trunk tomorrow, unless there are objections.
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4626-v2.txt, 4626.txt
>
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (HBASE-4626) Filters unnecessarily
copy byte arrays...
Posted by "Ted Yu (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131047#comment-13131047 ]
Ted Yu edited comment on HBASE-4626 at 10/19/11 9:56 PM:
---------------------------------------------------------
Interesting finding.
WritableByteArrayComparable should be enhanced with:
{code}
public int compareTo(byte[] buffer, int offset, int length)
{code}
which would delegate to this method in Bytes:
{code}
public static int compareTo(byte[] buffer1, int offset1, int length1,
byte[] buffer2, int offset2, int length2) {
{code}
was (Author: yuzhihong@gmail.com):
Interesting finding.
WritableByteArrayComparable should be enhanced with:
{code}
public int compareTo(byte[] buffer, int offset, int length)
{code}
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132318#comment-13132318 ]
Lars Hofhansl commented on HBASE-4626:
--------------------------------------
In the widest sense this could be considered an incompatible change. WritableByteArrayComparable is part of the public API and a client might have subclassed WritableByteArrayComparable in order pass it to a Filter. That would break now, as the client has to implement compareTo(byte[], int offset, int length) instead of compareTo(byte[]).
I'll hold off committing this to 0.92.
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4626-v2.txt, 4626-v3.txt, 4626.txt
>
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132371#comment-13132371 ]
Hudson commented on HBASE-4626:
-------------------------------
Integrated in HBase-TRUNK #2348 (See [https://builds.apache.org/job/HBase-TRUNK/2348/])
HBASE-4626 Filters unnecessarily copy byte arrays
larsh :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/BinaryComparator.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/BinaryPrefixComparator.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/BitComparator.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/CompareFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/NullComparator.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/RegexStringComparator.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/SubstringComparator.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/WritableByteArrayComparable.java
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4626-v2.txt, 4626-v3.txt, 4626.txt
>
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131086#comment-13131086 ]
Lars Hofhansl commented on HBASE-4626:
--------------------------------------
Exactly!
There are a bunch subclasses of WritableByteArrayComparable to deal with, so I refactored some code slightly.
The only funky thing is the NullComparator. All other comparators would fail with an NPE if a null byte[] is passed (even before my change); so for this one comparator I have the compareTo(byte[],int,int[]) method throw an unsupportedOperationException.
I have a patch. Running tests now.
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Posted by "Lars Hofhansl (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl resolved HBASE-4626.
----------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.92.0)
Hadoop Flags: Reviewed
I prefer to keep this in trunk only for now.
Please pull back in for 0.92 if you feel otherwise (the patch is simple and safe).
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4626-v2.txt, 4626-v3.txt, 4626.txt
>
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-4626:
---------------------------------
Attachment: 4626-v3.txt
I forgot to actually attach the right patch (the one that passes all test).
V2 is wrong... Does compareTo(val, offset, offset+length), should be compareTo(val, offset, length).
Nobody noticed :)
This patch passes all tests.
I did a quick and dirty performance test and it brought a full scan with SingleColValueValue from 163s to 105s.
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4626-v2.txt, 4626-v3.txt, 4626.txt
>
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131878#comment-13131878 ]
stack commented on HBASE-4626:
------------------------------
+1 on patch. I'm fine w/ it in 0.92 (doesn't have to go into 0.92 though).
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4626-v2.txt, 4626.txt
>
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-4626:
---------------------------------
Attachment: 4626-v2.txt
Fixed Javadoc
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4626-v2.txt, 4626.txt
>
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131370#comment-13131370 ]
Ted Yu commented on HBASE-4626:
-------------------------------
@Lars:
Since you have confidence in the patch, I think we should push it to 0.92
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4626-v2.txt, 4626.txt
>
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131203#comment-13131203 ]
Lars Hofhansl commented on HBASE-4626:
--------------------------------------
Also there are many more filters that do this kind of thing (all subclasses of CompareFilter).
All fixed now.
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4626.txt
>
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte
arrays...
Posted by "Jonathan Gray (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131378#comment-13131378 ]
Jonathan Gray commented on HBASE-4626:
--------------------------------------
I'm okay with this in 92 but would prefer it goes to 94. Put the perf in the next release so we release it soon.
> Filters unnecessarily copy byte arrays...
> -----------------------------------------
>
> Key: HBASE-4626
> URL: https://issues.apache.org/jira/browse/HBASE-4626
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.92.0, 0.94.0
>
> Attachments: 4626-v2.txt, 4626.txt
>
>
> Just looked at SingleCol and ValueFilter... And on every column compared they create a copy of the column and/or value portion of the KV.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira