[jira] [Comment Edited] (KYLIN-3182) Update Kylin help menu links

["peng.jianhua (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337011#comment-16337011 ] 

peng.jianhua edited comment on KYLIN-3182 at 1/24/18 6:41 AM:
--------------------------------------------------------------

Hi [~Zhixiong Chen], Thanks for your modification, but I think it is not enough.
If someone modifies the default configs in kylin.properties like this:

{code:java}
kylin.web.help.length=4
kylin.web.help.0=aa|aaa|
kylin.web.help.1=bb|bbb|
kylin.web.help.2=cc|ccc|
kylin.web.help.3=dd|ddd|
{code}

The issue will reappear again, so my modification is a protection against unusual configuration, and I think both of our modifications are the final solution, do you think so? can I summit a new combined patch? thanks!


was (Author: peng.jianhua):
Hi [~Zhixiong Chen], Thanks for your modification, but I think it is not enough.
If someone modifies the default configs in kylin.properties like this:

{code:java}
kylin.web.help.length=4
kylin.web.help.0=aa|aaa|
kylin.web.help.1=bb|bbb|
kylin.web.help.2=cc|ccc|
kylin.web.help.3=dd|ddd|
{code}

The issue will reappear again, so my modification is a protection against unusual configuration, and I think both of our modifications are the final solution, do you think so? thanks!

> Update Kylin help menu links
> ----------------------------
>
>                 Key: KYLIN-3182
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3182
>             Project: Kylin
>          Issue Type: Bug
>          Components: Web 
>    Affects Versions: v2.3.0
>            Reporter: peng.jianhua
>            Assignee: Zhixiong Chen
>            Priority: Major
>              Labels: patch
>             Fix For: v2.3.0
>
>         Attachments: 0001-KYLIN-3182-Kylin-Help-is-not-available.patch, 0001-KYLIN-3182-complete-web-help-configuration.patch, help_blank.png
>
>
> Kylin Help is not available, look like
>   !help_blank.png! 
> Then I analyse the web code, and find the problem.
> The default help informations have been configured in the 'kylin-defaults.properties', as follow
> {code:java}
> kylin.web.help.length=4
> kylin.web.help.0=start|Getting Started|
> kylin.web.help.1=odbc|ODBC Driver|
> kylin.web.help.2=tableau|Tableau Guide|
> kylin.web.help.3=onboard|Cube Design Tutorial|
> {code}
> The all links haven't been configured, but the web page will judge whether the link is empty, if the link is empty, the item under the 'Help' will not be showed.
> So I modified the web code, if the link of help document is null, it will be discarded, not transformed to header page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)